From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 87DD9198005 for ; Sat, 2 Mar 2013 15:14:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6E3D6E064E; Sat, 2 Mar 2013 15:13:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 757EBE062D for ; Sat, 2 Mar 2013 15:13:49 +0000 (UTC) Received: from [192.168.4.5] (blfd-4d08f589.pool.mediaWays.net [77.8.245.137]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: hasufell) by smtp.gentoo.org (Postfix) with ESMTPSA id 1AF0A33DC93 for ; Sat, 2 Mar 2013 15:13:47 +0000 (UTC) Message-ID: <51321726.7000808@gentoo.org> Date: Sat, 02 Mar 2013 16:13:42 +0100 From: hasufell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130123 Thunderbird/17.0.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] New eclass: autotools-multilib-minimal References: <51296027.705@gentoo.org> <512A9691.5090503@gentoo.org> <512EAD91.7030405@gentoo.org> <20130228093014.62d3e9ce@pomiocik.lan> <513168E3.9070904@gentoo.org> <20130302160718.35b39774@pomiocik.lan> In-Reply-To: <20130302160718.35b39774@pomiocik.lan> X-Enigmail-Version: 1.5 Content-Type: multipart/mixed; boundary="------------080004010906090107000908" X-Archives-Salt: 8007f97e-27f7-4064-9ae1-0337fe5c7ada X-Archives-Hash: f0a4e1caf6157eaf37b991af9f7217c5 This is a multi-part message in MIME format. --------------080004010906090107000908 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/02/2013 04:07 PM, Michał Górny wrote: > I don't think you should introduce workarounds in your eclass. I think > multilib-build should be the place to do that. Feel free to implement a solution. I think an explicit variable might even be better instead of some magical checks which could cause unexpected behavior for in-source builds or ebuilds that do a lot of additional stuff on top of these eclasses. So in case that solution breaks something, it would only be for multilib-portage and they could still handle that via masking those packages. > > And please don't attach patches to patched version since that's too > hard to follow. > I didn't. However, here is the full version. --------------080004010906090107000908 Content-Type: text/plain; charset=UTF-8; name="multilib-minimal.eclass" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="multilib-minimal.eclass" IyBDb3B5cmlnaHQgMTk5OS0yMDEzIEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQg dW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2Mgoj ICRIZWFkZXI6ICQKCiMgQEVDTEFTUzogbXVsdGlsaWItbWluaW1hbC5lY2xhc3MKIyBATUFJ TlRBSU5FUjoKIyBKdWxpYW4gT3NwYWxkIDxoYXN1ZmVsbEBnZW50b28ub3JnPgojIEBCTFVS Qjogd3JhcHBlciBmb3IgbXVsdGlsaWIgYnVpbGRzIHByb3ZpZGluZyBjb252ZW5pZW50IG11 bHRpbGliX3NyY18qIGZ1bmN0aW9ucwojIEBERVNDUklQVElPTjoKIwojIHNyY19jb25maWd1 cmUsIHNyY19jb21waWxlLCBzcmNfdGVzdCBhbmQgc3JjX2luc3RhbGwgYXJlIGV4cG9ydGVk CiMgdXNlIG11bHRpbGliX3NyY18qIGluc3RlYWQgb2Ygc3JjXyogd2hpY2ggcnVucyB0aGlz IHBoYXNlIGZvcgojIGFsbCBlbmFibGVkIEFCSXMKIyBtdWx0aWxpYi1taW5pbWFsIHNob3Vs ZCBfYWx3YXlzXyBnbyBsYXN0IGluIGluaGVyaXQgb3JkZXIhIQojCiMgSWYgeW91IGFyZSB1 c2luZyBpbi1zb3VyY2UgYnVpbGRzLCB0aGVuIHlvdSBtdXN0IHJ1biBtdWx0aWxpYl9jb3B5 X3NvdXJjZXMKIyBhdCB0aGUgZW5kIG9mIHNyY19wcmVwYXJlISEKIwojIElmIHlvdSBuZWVk IGdlbmVyaWMgaW5zdGFsbCBydWxlcywgdXNlIG11bHRpbGliX3NyY19pbnN0YWxsX2FsbCBm dW5jdGlvbi4KCgojIEVBUEk9NSBpcyByZXF1aXJlZCBmb3IgbWVhbmluZ2Z1bCBNVUxUSUxJ Ql9VU0VERVAuCmNhc2UgJHtFQVBJOi0wfSBpbgoJNSkgOzsKCSopIGRpZSAiRUFQST0ke0VB UEl9IGlzIG5vdCBzdXBwb3J0ZWQiIDs7CmVzYWMKCgppbmhlcml0IG11bHRpbGliLWJ1aWxk CgpFWFBPUlRfRlVOQ1RJT05TIHNyY19jb25maWd1cmUgc3JjX2NvbXBpbGUgc3JjX3Rlc3Qg c3JjX2luc3RhbGwKCgp1bnNldCBESVNBQkxFX01VTFRJTElCCl9tdWx0aWxpYi1taW5pbWFs X3NldF9nbG9iYWxzKCkgewoJaWYgW1sgJChtdWx0aWxpYl9nZXRfZW5hYmxlZF9hYmlzKSA9 PSAke0RFRkFVTFRfQUJJfSBdXSA7IHRoZW4KCQlESVNBQkxFX01VTFRJTElCPSJPTiIKCWZp Cn0KX211bHRpbGliLW1pbmltYWxfc2V0X2dsb2JhbHMKCgptdWx0aWxpYl9jb3B5X3NvdXJj ZXMoKSB7CglfYWJpX2NvcHlfc291cmNlcygpIHsKCQllaW5mbyAiJHtBQkl9OiBjb3B5aW5n IHRvICR7QlVJTERfRElSfSIKCQljcCAtcFIgIiR7U30iICIke0JVSUxEX0RJUn0iIHx8IGRp ZSAiZmFpbGVkIHRvIGNvcHkgc291cmNlcyIKCX0KCglpZiBbWyAteiAke0RJU0FCTEVfTVVM VElMSUJ9IF1dIDsgdGhlbgoJCWVpbmZvICJXaWxsIGNvcHkgc291cmNlcyB0byBhYmktc3Bl Y2lmaWMgZGlycyIKCQltdWx0aWxpYl9mb3JlYWNoX2FiaSBfYWJpX2NvcHlfc291cmNlcwoJ ZmkKfQoKbXVsdGlsaWItbWluaW1hbF9zcmNfY29uZmlndXJlKCkgewoJX2NvbW1vbl9zcmNf Y29uZmlndXJlKCkgewoJCWlmIGRlY2xhcmUgLWYgbXVsdGlsaWJfc3JjX2NvbmZpZ3VyZSA+ L2Rldi9udWxsIDsgdGhlbgoJCQltdWx0aWxpYl9zcmNfY29uZmlndXJlCgkJZWxzZQoJCQlk ZWZhdWx0X3NyY19jb25maWd1cmUKCQlmaQoJfQoKCV9hYmlfc3JjX2NvbmZpZ3VyZSgpIHsK CQllaW5mbyAiJHtBQkl9OiBDb25maWd1cmluZyIKCgkJbWtkaXIgLXAgIiR7QlVJTERfRElS fSIgfHwgZGllCgkJcHVzaGQgIiR7QlVJTERfRElSfSIgPi9kZXYvbnVsbCB8fCBkaWUKCQlf Y29tbW9uX3NyY19jb25maWd1cmUKCQlwb3BkID4vZGV2L251bGwgfHwgZGllCgl9CgoJaWYg W1sgLXogJHtESVNBQkxFX01VTFRJTElCfSBdXSA7IHRoZW4KCQltdWx0aWxpYl9mb3JlYWNo X2FiaSBfYWJpX3NyY19jb25maWd1cmUKCWVsc2UKCQlfY29tbW9uX3NyY19jb25maWd1cmUK CWZpCQp9CgptdWx0aWxpYi1taW5pbWFsX3NyY19jb21waWxlKCkgewoJX2NvbW1vbl9zcmNf Y29tcGlsZSgpIHsKCQlpZiBkZWNsYXJlIC1mIG11bHRpbGliX3NyY19jb21waWxlID4vZGV2 L251bGwgOyB0aGVuCgkJCW11bHRpbGliX3NyY19jb21waWxlCgkJZWxzZQoJCQlkZWZhdWx0 X3NyY19jb21waWxlCgkJZmkKCX0KCglfYWJpX3NyY19jb21waWxlKCkgewoJCWVpbmZvICIk e0FCSX06IENvbXBpbGluZyIKCgkJcHVzaGQgIiR7QlVJTERfRElSfSIgPi9kZXYvbnVsbCB8 fCBkaWUKCQlfY29tbW9uX3NyY19jb21waWxlCgkJcG9wZCA+L2Rldi9udWxsIHx8IGRpZQoJ fQoKCWlmIFtbIC16ICR7RElTQUJMRV9NVUxUSUxJQn0gXV0gOyB0aGVuCgkJbXVsdGlsaWJf Zm9yZWFjaF9hYmkgX2FiaV9zcmNfY29tcGlsZQoJZWxzZQoJCV9jb21tb25fc3JjX2NvbXBp bGUKCWZpCn0KCm11bHRpbGliLW1pbmltYWxfc3JjX3Rlc3QoKSB7CglfY29tbW9uX3NyY190 ZXN0KCkgewoJCWlmIGRlY2xhcmUgLWYgbXVsdGlsaWJfc3JjX3Rlc3QgPi9kZXYvbnVsbCA7 IHRoZW4KCQkJbXVsdGlsaWJfc3JjX3Rlc3QKCQllbHNlCgkJCWRlZmF1bHRfc3JjX3Rlc3QK CQlmaQoJfQoKCV9hYmlfc3JjX3Rlc3QoKSB7CgkJZWluZm8gIiR7QUJJfTogVGVzdGluZyIK CgkJcHVzaGQgIiR7QlVJTERfRElSfSIgPi9kZXYvbnVsbCB8fCBkaWUKCQlfY29tbW9uX3Ny Y190ZXN0CgkJcG9wZCA+L2Rldi9udWxsIHx8IGRpZQoJfQoKCWlmIFtbIC16ICR7RElTQUJM RV9NVUxUSUxJQn0gXV0gOyB0aGVuCgkJbXVsdGlsaWJfZm9yZWFjaF9hYmkgX2FiaV9zcmNf dGVzdAoJZWxzZQoJCV9jb21tb25fc3JjX3Rlc3QKCWZpCn0KCm11bHRpbGliLW1pbmltYWxf c3JjX2luc3RhbGwoKSB7CglfY29tbW9uX3NyY19pbnN0YWxsKCkgewoJCWlmIGRlY2xhcmUg LWYgbXVsdGlsaWJfc3JjX2luc3RhbGwgPi9kZXYvbnVsbCA7IHRoZW4KCQkJbXVsdGlsaWJf c3JjX2luc3RhbGwKCQllbHNlCgkJCWRlZmF1bHRfc3JjX2luc3RhbGwJCgkJZmkKCX0KCglf YWJpX3NyY19pbnN0YWxsKCkgewoJCWVpbmZvICIke0FCSX06IEluc3RhbGxpbmciCgoJCXB1 c2hkICIke0JVSUxEX0RJUn0iID4vZGV2L251bGwgfHwgZGllCgkJX2NvbW1vbl9zcmNfaW5z dGFsbAoJCW11bHRpbGliX2NoZWNrX2hlYWRlcnMKCQlwb3BkID4vZGV2L251bGwgfHwgZGll Cgl9CgoJaWYgW1sgLXogJHtESVNBQkxFX01VTFRJTElCfSBdXSA7IHRoZW4KCQltdWx0aWxp Yl9mb3JlYWNoX2FiaSBfYWJpX3NyY19pbnN0YWxsCgllbHNlCgkJX2NvbW1vbl9zcmNfaW5z dGFsbAoJZmkKCglpZiBkZWNsYXJlIC1mIG11bHRpbGliX3NyY19pbnN0YWxsX2FsbCA+L2Rl di9udWxsIDsgdGhlbgoJCW11bHRpbGliX3NyY19pbnN0YWxsX2FsbAoJZmkKfQo= --------------080004010906090107000908--