public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Diego Elio Pettenò" <flameeyes@flameeyes.eu>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/freetype: freetype-2.4.11-r1.ebuild ChangeLog
Date: Wed, 27 Feb 2013 19:15:51 +0100	[thread overview]
Message-ID: <512E4D57.5040002@flameeyes.eu> (raw)
In-Reply-To: <512E3E06.8010205@gentoo.org>

On 27/02/2013 18:10, hasufell wrote:
> a) if you break a provider on purpose, then you should feel
>  somehow responsible for the consumers and not just dump testing and
> fixing on your fellow devs

I'd say the only real mistake has been not keeping it masked to begin with.

Just so we're clear with everybody, I would suggest, the next time
somebody wants to introduce a disruptive change:

 1. commit it masked — this way even if it's going to mess up the whole
tree you won't be blamed;
 2. ask me for testing — this happened in this case, but (1) was missed;
 3. make sure you're around to keep the pieces.

I opened the bugs — I wasn't going to look into them any time soon,
mostly because I got another huge bunch of bugs already — I started
today, and after a while it became obvious (to hasufell) that many of
them came down to the same issue; now I know and I'm not opening bugs
for the same issue all over.

Another common one I found myself simply because I noticed it while
looking at the build log.

I don't see a big problem with 3. as Michał might not have reacted yet,
but it was not even 24 hours since he asked me to run the tinderbox. He
might have caught the cmake issue himself, I don't know.

So my final word is that yes, this was a screw up, no, not as big as it
transpire from here.

-- 
Diego Elio Pettenò — Flameeyes
flameeyes@flameeyes.eu — http://blog.flameeyes.eu/


  parent reply	other threads:[~2013-02-27 18:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130225222029.D84D12171D@flycatcher.gentoo.org>
2013-02-27 17:10 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/freetype: freetype-2.4.11-r1.ebuild ChangeLog hasufell
2013-02-27 17:58   ` Alexis Ballier
2013-02-27 18:14     ` hasufell
2013-02-27 18:27       ` Alexis Ballier
2013-02-27 19:05         ` hasufell
2013-02-27 19:09           ` Ciaran McCreesh
2013-03-02 11:08           ` Alexis Ballier
2013-03-02 15:01             ` hasufell
2013-02-27 20:25         ` Pacho Ramos
2013-02-27 21:12           ` Thomas Sachau
2013-03-02 10:55             ` Alexis Ballier
2013-02-27 20:30     ` Pacho Ramos
2013-02-27 21:08     ` Thomas Sachau
2013-02-27 21:18       ` Michał Górny
2013-03-02 10:53       ` Alexis Ballier
2013-02-27 18:15   ` Diego Elio Pettenò [this message]
2013-02-27 20:20   ` Pacho Ramos
2013-02-27 20:23     ` Ciaran McCreesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E4D57.5040002@flameeyes.eu \
    --to=flameeyes@flameeyes.eu \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox