Re: [gentoo-dev] New eclass: autotools-multilib-minimal

[hasufell <hasufell@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On 02/24/2013 05:22 PM, Alexis Ballier wrote:
> On Sun, 24 Feb 2013 01:34:47 +0100
> hasufell <hasufell@gentoo.org> wrote:
> 
>> Some people seem to feel uncomfortable with autotools-multilib,
>> because it depends on autotools-utils.
> 
> To be honest, I don't particularly like autotools-utils, I tend to
> consider it a useless bloat. However, Michal's work on
> autotools-multilib is IMHO the right thing to do: If you use the
> autotools-utils syntax then it's trivial to support multilib without
> useless duplication of code.
> I still believe such an eclass as the one you propose is useful, except
> it's not for autotools (at best temporary for broken autotools based
> build systems): For example, I have no clue how to do multilib with
> waf-based build systems without going the 'copy $S and run the usual
> src_* phases in each directory for each ABI', which is what your eclass
> is abstracting I think.
> 
> A.
> 

I have no idea if it makes sense for this package (since it also
installs binaries), but as an example I have converted dev-libs/serd.

And yes, a rename of the eclass would probably be appropriate.

[-- Attachment #2: serd-0.18.2.ebuild.diff --]
[-- Type: text/plain, Size: 1018 bytes --]

--- dev-libs/serd/serd-0.18.2.ebuild
+++ dev-libs/serd/serd-0.18.2-r1.ebuild
@@ -2,9 +2,9 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-libs/serd/serd-0.18.2.ebuild,v 1.1 2013/01/13 21:08:17 aballier Exp $
 
-EAPI=4
-
-inherit waf-utils
+EAPI=5
+AUTOTOOLS_IN_SOURCE_BUILD=1
+inherit waf-utils autotools-multilib-minimal
 
 DESCRIPTION="Library for RDF syntax which supports reading and writing Turtle and NTriples"
 HOMEPAGE="http://drobilla.net/software/serd/"
@@ -23,9 +23,10 @@
 
 src_prepare() {
 	sed -i -e 's/^.*run_ldconfig/#\0/' wscript || die
+	prepabisources
 }
 
-src_configure() {
+multilib_src_configure() {
 	waf-utils_src_configure \
 		--docdir=/usr/share/doc/${PF} \
 		$(use test && echo "--test") \
@@ -33,6 +34,14 @@
 		$(use static-libs && echo "--static")
 }
 
-src_test() {
+multilib_src_test() {
 	./waf test || die
 }
+
+multilib_src_compile() {
+	waf-utils_src_compile
+}
+
+multilib_src_install() {
+	waf-utils_src_install
+}