From: hasufell <hasufell@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] New eclass: autotools-multilib-minimal
Date: Sun, 24 Feb 2013 16:12:06 +0100 [thread overview]
Message-ID: <512A2DC6.8040809@gentoo.org> (raw)
In-Reply-To: <20130224155715.428b0493@pomiocik.lan>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/24/2013 03:57 PM, Michał Górny wrote:
> On Sun, 24 Feb 2013 05:22:43 +0100 hasufell <hasufell@gentoo.org>
> wrote:
>
>> Before people start asking I should explain why I started this:
>> https://bugs.gentoo.org/show_bug.cgi?id=458638
>>
>> I think having such an eclass has several advantages over
>> autootools-multilib.eclass (which depends on
>> autotools-utils.eclass) as it is now:
>
> You wanted the other points, so here you go.
>
>> a) Less eclass dependencies. One could argue: the more eclasses
>> my ebuild uses the more prone to error and exposed to changes it
>> is.
>
> That's as good as bundling libraries. Really.
That analogy is flawed. It's about ebuild design and the fact that I
don't just convert my ebuild to _multilib_, but also to
_autotools-utils_, so I have to keep an eye on another provider.
>
>> b) easier conversion in some cases: often times a simple rename
>> src_compile -> multilib_src_compile will do
>
> Easy != good. The eclass switch is a good point to fix bugs which
> should have been fixed long ago. By making it unnecessary, you
> just keep those bugs live and hidden.
>
>> c) it allows more custom definition of phase functions
>
> More custom than what?
Than autotools-multilib.eclass.
>
>> d) the previous point will also allow to convert go-mono.eclass
>> packages without introducing yet another eclass for that
>
> So you're introducing a hacky eclass just because you're too lazy
> to convert go-mono packages properly and too impatient to let
> others do the work properly for you?
Please point out where the eclass is hacky. I haven't heard a
technical argument against it despite that you think
autotools-multilib.eclass is better.
That might be true, but then I don't understand why people refuse to
use it which is the only reason I am proposing this.
Also, I am not too lazy to convert go-mono packages. I have already
written the go-mono-multilib.eclass and it looks almost the same as
autotools-multilib-minimal.eclass, so I am wondering why I want
code-duplication in eclasses.
>
>> e) autotools-utils.eclass does a bit more than just calling
>> default phase functions; the developer has little choice on this
>> matter unless he wants to rewrite his ebuild based on
>> multilib-build.eclass which will create a lot of code duplication
>> in ebuilds, hence this proposition
>
> And as I already told you, this argument just proves that you
> don't know the eclass in question and just throwing random
> accusations.
>
No, I was just rephrasing other peoples concerns.
>> I don't have a problem with the present eclasses, but I find this
>> a logical enhancement.
>
> If that's logical, then please provide a graph showing where it
> logically fits. Because so far, it's either hate-built redundant
> eclass or quick draft eclass written for a single package.
>
I don't understand you.
It works on more than one package.
Anyway... as I said, I don't care how this problem is solved. I only
care about the availability of 32bit libs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJRKi3GAAoJEFpvPKfnPDWzkW4H/3uaQ++8Rky1GKi+Tvffz45i
x+yNpPtje/gWFKjXVeWxQZfNV/tLsq1TZM0ruzixB6lO1vFD6Ql+8ZiuTrHHRvuV
at3+iT2AycSTeNs0qRUHjICOn5V6fMNQyIxJsrFS+HNEEbYfE36+S91YvN9WwHr6
Q2PDBp+3jueJXNVeZh+zdSQL4eo2fEuJ39/pa42SPbeRGGm6aw1SnhD9RYBcRZuf
GyuTOk7R+vwp55i4d7xXyb8eEDVh7uSqikb7OniNA15a7wrmpSLsfwonhZS/a3Qq
R/pQDXGm+aDDk7ZwXGCWRvGd7ARLqED5A+5yKcfyQeZ99RP6KHW8+xEwkr8M54I=
=3uKD
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-02-24 15:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 0:34 [gentoo-dev] New eclass: autotools-multilib-minimal hasufell
2013-02-24 4:22 ` hasufell
2013-02-24 10:06 ` Michał Górny
2013-02-24 10:11 ` Diego Elio Pettenò
2013-02-24 14:17 ` hasufell
2013-02-24 14:33 ` Pacho Ramos
2013-02-27 13:01 ` Samuli Suominen
2013-02-27 20:13 ` Michał Górny
2013-02-27 20:15 ` Pacho Ramos
2013-02-24 14:57 ` Michał Górny
2013-02-24 15:12 ` hasufell [this message]
2013-02-24 15:12 ` Pacho Ramos
2013-02-24 15:53 ` Michał Górny
2013-02-24 16:21 ` Pacho Ramos
2013-02-24 16:28 ` Alexis Ballier
2013-02-24 16:58 ` Samuli Suominen
2013-02-24 18:56 ` Michał Górny
2013-02-24 19:40 ` hasufell
2013-02-24 18:05 ` [gentoo-dev] " Jonathan Callen
2013-02-24 18:18 ` Michał Górny
2013-02-24 16:22 ` [gentoo-dev] " Alexis Ballier
2013-02-24 16:42 ` hasufell
2013-02-24 18:46 ` Alexis Ballier
2013-02-24 22:39 ` Samuli Suominen
2013-02-28 1:06 ` hasufell
2013-02-28 8:30 ` Michał Górny
2013-02-28 15:16 ` hasufell
2013-03-02 2:50 ` hasufell
2013-03-02 15:07 ` Michał Górny
2013-03-02 15:13 ` hasufell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512A2DC6.8040809@gentoo.org \
--to=hasufell@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox