[gentoo-dev] games.eclass: handle verbose build log for egamesconf in EAPI<5

[gentoo-dev] games.eclass: handle verbose build log for egamesconf in EAPI<5

[hasufell]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

already filed a bug, but no response so far
https://bugs.gentoo.org/show_bug.cgi?id=444478

any comments?

This is sane imo, cause some games herd developers don't agree with the
"always latest EAPI" thing which is no official policy anyway.

[-- Attachment #2: games.eclass.diff --]
[-- Type: text/plain, Size: 530 bytes --]

--- eclass/games.eclass
+++ eclass/games.eclass
@@ -39,12 +39,21 @@
 }
 
 egamesconf() {
+	# handle verbose build log pre-EAPI5
+	local _gamesconf=""
+	if has "${EAPI:-0}" 0 1 2 3 4 ; then
+		case $(./configure --help) in
+			*--disable-silent-rules*) _gamesconf="--disable-silent-rules";;
+		esac
+	fi
+
 	econf \
 		--prefix="${GAMES_PREFIX}" \
 		--libdir="$(games_get_libdir)" \
 		--datadir="${GAMES_DATADIR}" \
 		--sysconfdir="${GAMES_SYSCONFDIR}" \
 		--localstatedir="${GAMES_STATEDIR}" \
+		${_gamesconf} \
 		"$@"
 }
 

Re: [gentoo-dev] games.eclass: handle verbose build log for egamesconf in EAPI<5

[Tomáš Chvátal]

There are better ways to do this.

For example you can just grep through the configure file, not having
to invoke it, see the xorg-2.elass

Tom

2012/12/2 hasufell <hasufell@gentoo.org>:
> already filed a bug, but no response so far
> https://bugs.gentoo.org/show_bug.cgi?id=444478
>
> any comments?
>
> This is sane imo, cause some games herd developers don't agree with the
> "always latest EAPI" thing which is no official policy anyway.

Re: [gentoo-dev] games.eclass: handle verbose build log for egamesconf in EAPI<5

[hasufell]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

On 12/02/2012 05:39 PM, Tomáš Chvátal wrote:
> There are better ways to do this.
> 
> For example you can just grep through the configure file, not having
> to invoke it, see the xorg-2.elass
> 

[-- Attachment #2: games.eclass.diff --]
[-- Type: text/plain, Size: 530 bytes --]

--- games.eclass
+++ games.eclass
@@ -39,12 +39,21 @@
 }
 
 egamesconf() {
+	# handle verbose build log pre-EAPI5
+	local _gamesconf=""
+	if has "${EAPI:-0}" 0 1 2 3 4 ; then
+		if grep -q -s "disable-silent-rules" "${ECONF_SOURCE:-.}/configure"; then
+			_gamesconf="--disable-silent-rules"
+		fi
+	fi
+
 	econf \
 		--prefix="${GAMES_PREFIX}" \
 		--libdir="$(games_get_libdir)" \
 		--datadir="${GAMES_DATADIR}" \
 		--sysconfdir="${GAMES_SYSCONFDIR}" \
 		--localstatedir="${GAMES_STATEDIR}" \
+		${_gamesconf} \
 		"$@"
 }