From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7E208138010 for ; Mon, 29 Oct 2012 15:26:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 33C3321C020; Mon, 29 Oct 2012 15:26:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 72A1521C010 for ; Mon, 29 Oct 2012 15:25:35 +0000 (UTC) Received: from [192.168.1.132] (CPE002401f30b73-CM001cea3ddad8.cpe.net.cable.rogers.com [99.240.69.152]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: axs) by smtp.gentoo.org (Postfix) with ESMTPSA id 9396133D860 for ; Mon, 29 Oct 2012 15:25:34 +0000 (UTC) Message-ID: <508E9FED.6000905@gentoo.org> Date: Mon, 29 Oct 2012 11:25:33 -0400 From: Ian Stakenvicius User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120925 Thunderbird/10.0.7 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example). References: <1351335771-3618-1-git-send-email-mgorny@gentoo.org> <1351335771-3618-5-git-send-email-mgorny@gentoo.org> In-Reply-To: <1351335771-3618-5-git-send-email-mgorny@gentoo.org> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Archives-Salt: 267d21b5-c662-4976-a0d4-2f7c4158970d X-Archives-Hash: 39b9e503279ea14784d7dfb6bba77533 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 27/10/12 07:02 AM, Micha? Górny wrote: > This serves as an example how the new functions can be used. --- > gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33 > ++++++++++++--------------- 1 file changed, 14 insertions(+), 19 > deletions(-) > > diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index > f3bd210..589e571 100644 --- > a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++ > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8 @@ > COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb geoclue? ( > app-misc/geoclue ) gnome? ( dev-libs/glib:2 - >=gnome-base/gconf-2 > )" + >=gnome-base/gconf-2 ) + gtk? ( ${PYTHON_DEPS} )" > RDEPEND="${COMMON_DEPEND} gtk? ( >=dev-python/pygtk-2 > dev-python/pyxdg )" ..should we not also ensure that the PYTHON_TARGETS for pygtk-2 and pyxdg match (or at least include) the PYTHON_TARGETS being used for this package? IE: > RDEPEND="${COMMON_DEPEND} - gtk? ( >=dev-python/pygtk-2 - > dev-python/pyxdg )" + gtk? ( >=dev-python/pygtk-2[$PYTHON_USEDEP] > + dev-python/pyxdg[$PYTHON_USEDEP] )" I don't know if this is actually needed by the package but I would assume so as it seems to be building and installing for multiple pythons.. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iF4EAREIAAYFAlCOn+wACgkQ2ugaI38ACPBumgD9FDoSOvYTftLxQuo6Hix6ud9l eZ0f5iLnD2SfzaaWcxwA/022wryA/f+f0ebg9WmS+C4AuzNvCQMQe7El3ERuAw23 =KDxM -----END PGP SIGNATURE-----