public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ian Stakenvicius <axs@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example).
Date: Mon, 29 Oct 2012 11:25:33 -0400	[thread overview]
Message-ID: <508E9FED.6000905@gentoo.org> (raw)
In-Reply-To: <1351335771-3618-5-git-send-email-mgorny@gentoo.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 27/10/12 07:02 AM, Micha? Górny wrote:
> This serves as an example how the new functions can be used. --- 
> gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33
> ++++++++++++--------------- 1 file changed, 14 insertions(+), 19
> deletions(-)
> 
> diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild
> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index
> f3bd210..589e571 100644 ---
> a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++
> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8 @@
> COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb geoclue? (
> app-misc/geoclue ) gnome? ( dev-libs/glib:2 -		>=gnome-base/gconf-2
> )" +		>=gnome-base/gconf-2 ) +	gtk? ( ${PYTHON_DEPS} )" 
> RDEPEND="${COMMON_DEPEND} gtk? ( >=dev-python/pygtk-2 
> dev-python/pyxdg )"


..should we not also ensure that the PYTHON_TARGETS for pygtk-2 and
pyxdg match (or at least include) the PYTHON_TARGETS being used for
this package?  IE:

> RDEPEND="${COMMON_DEPEND} - 	gtk? ( >=dev-python/pygtk-2 -
> dev-python/pyxdg )" + 	gtk? ( >=dev-python/pygtk-2[$PYTHON_USEDEP] 
> + 		dev-python/pyxdg[$PYTHON_USEDEP] )"


I don't know if this is actually needed by the package but I would
assume so as it seems to be building and installing for multiple pythons..
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF4EAREIAAYFAlCOn+wACgkQ2ugaI38ACPBumgD9FDoSOvYTftLxQuo6Hix6ud9l
eZ0f5iLnD2SfzaaWcxwA/022wryA/f+f0ebg9WmS+C4AuzNvCQMQe7El3ERuAw23
=KDxM
-----END PGP SIGNATURE-----


  reply	other threads:[~2012-10-29 15:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 11:02 [gentoo-dev] [PATCH python-r1 1/8] python_export: support obtaining site-packages directory Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 2/8] Add getter-style wrappers for python_export() Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 3/8] Add python_export_best() to obtain best impl info Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 4/8] Introduce functions to replicate Python scripts Michał Górny
2012-10-27 13:27   ` Reinis Danne
2012-10-27 14:08     ` Michał Górny
2012-10-27 14:31       ` Reinis Danne
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example) Michał Górny
2012-10-29 15:25   ` Ian Stakenvicius [this message]
2012-10-29 15:42     ` Michał Górny
2012-10-29 15:47       ` Ian Stakenvicius
2012-10-29 16:14         ` Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 6/8] Reuse _python_ln_rel in distutils-r1 Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 7/8] Use python_export_best() " Michał Górny
2012-10-27 11:02 ` [gentoo-dev] [PATCH python-r1 8/8] Use find instead of hard-coded path list when looking for scripts Michał Górny
2012-10-27 14:16 ` [gentoo-dev] [PATCH python-r1] Depend on python-exec in python-r1 Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508E9FED.6000905@gentoo.org \
    --to=axs@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox