From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-55121-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 55403138010
	for <garchives@archives.gentoo.org>; Thu, 27 Sep 2012 17:08:46 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 2DE0D21C026;
	Thu, 27 Sep 2012 17:08:31 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 1F17321C006
	for <gentoo-dev@lists.gentoo.org>; Thu, 27 Sep 2012 17:07:46 +0000 (UTC)
Received: from [192.168.42.148] (staff-wireless.saddleback.edu [209.129.85.50])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: zmedico)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 5A80833C394;
	Thu, 27 Sep 2012 17:07:45 +0000 (UTC)
Message-ID: <506487E1.20301@gentoo.org>
Date: Thu, 27 Sep 2012 10:07:45 -0700
From: Zac Medico <zmedico@gentoo.org>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120901 Thunderbird/15.0
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
To: gentoo-dev@lists.gentoo.org
CC: Ulrich Mueller <ulm@gentoo.org>
Subject: Re: [gentoo-dev] patch eutils.eclass for EAPI 5
References: <20580.33667.617825.108101@a1i15.kph.uni-mainz.de>
In-Reply-To: <20580.33667.617825.108101@a1i15.kph.uni-mainz.de>
X-Enigmail-Version: 1.4.4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 83634907-e039-4dd2-8317-6cdfb64f4c2e
X-Archives-Hash: 278710aa43ec88ef31be131faf1bf20c

On 09/27/2012 09:49 AM, Ulrich Mueller wrote:
> As far as I can see, only the definition of the usex function must be
> disabled. Please review the patch included below.
> 
> Ulrich
> 
> --- eutils.eclass	15 Sep 2012 16:16:53 -0000	1.403
> +++ eutils.eclass	27 Sep 2012 16:45:14 -0000
> @@ -1373,7 +1373,9 @@
>  # @DESCRIPTION:
>  # If USE flag is set, echo [true output][true suffix] (defaults to "yes"),
>  # otherwise echo [false output][false suffix] (defaults to "no").
> +if has "${EAPI:-0}" 0 1 2 3 4; then
>  usex() { use "$1" && echo "${2-yes}$4" || echo "${3-no}$5" ; } #382963
> +fi
>  
>  # @FUNCTION: prune_libtool_files
>  # @USAGE: [--all]
> 

Looks good to me.

It may not work for unofficial EAPIs that don't include usex, but I
guess there's nothing we can do for those, and they can just be replaced
with newer EAPIs that include usex.
-- 
Thanks,
Zac