* [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
[not found] <20120807152154.99BEE2004B@flycatcher.gentoo.org>
@ 2012-08-07 16:03 ` Torsten Veller
2012-08-07 16:23 ` Michał Górny
2012-08-07 16:26 ` Fabian Groffen
0 siblings, 2 replies; 5+ messages in thread
From: Torsten Veller @ 2012-08-07 16:03 UTC (permalink / raw
To: gentoo-dev, grobian
* "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> grobian 12/08/07 15:21:54
>
> Modified: ChangeLog
> Added: XML-Parser-2.410.0-r1.ebuild
> Log:
> Fix expat detection for FreeBSD that silently went unnoticed.
The following single quotes were dropped:
-myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
+myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"
Sorry, I don't understand the problem. Is it a general problem with
the single quote or a special FreeBSD problem?
I think we should convert all myconf strings to arrays:
myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )
--
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
2012-08-07 16:03 ` [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog Torsten Veller
@ 2012-08-07 16:23 ` Michał Górny
2012-08-07 16:28 ` Fabian Groffen
2012-08-07 16:26 ` Fabian Groffen
1 sibling, 1 reply; 5+ messages in thread
From: Michał Górny @ 2012-08-07 16:23 UTC (permalink / raw
To: gentoo-dev; +Cc: tove, grobian
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On Tue, 7 Aug 2012 18:03:14 +0200
Torsten Veller <tove@gentoo.org> wrote:
> * "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> > grobian 12/08/07 15:21:54
> >
> > Modified: ChangeLog
> > Added: XML-Parser-2.410.0-r1.ebuild
> > Log:
> > Fix expat detection for FreeBSD that silently went unnoticed.
>
> The following single quotes were dropped:
>
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)'
> EXPATINCPATH='${EPREFIX}/usr/include'"
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
> EXPATINCPATH=${EPREFIX}/usr/include"
>
> Sorry, I don't understand the problem. Is it a general problem with
> the single quote or a special FreeBSD problem?
A general problem. It won't work unless it's eval-ed. And if it were,
there will be more harm than you can possibly imagine.
> I think we should convert all myconf strings to arrays:
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir)
> EXPATINCPATH="${EPREFIX}"/usr/include )
+1.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
2012-08-07 16:03 ` [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog Torsten Veller
2012-08-07 16:23 ` Michał Górny
@ 2012-08-07 16:26 ` Fabian Groffen
2012-08-08 21:04 ` vivo75
1 sibling, 1 reply; 5+ messages in thread
From: Fabian Groffen @ 2012-08-07 16:26 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
On 07-08-2012 18:03:14 +0200, Torsten Veller wrote:
> * "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> > grobian 12/08/07 15:21:54
> >
> > Modified: ChangeLog
> > Added: XML-Parser-2.410.0-r1.ebuild
> > Log:
> > Fix expat detection for FreeBSD that silently went unnoticed.
>
> The following single quotes were dropped:
>
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"
>
> Sorry, I don't understand the problem. Is it a general problem with
> the single quote or a special FreeBSD problem?
I've only observed it happening on FreeBSD indeed.
> I think we should convert all myconf strings to arrays:
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )
I don't understand enough of the Makefile.PL thing to tell why the
quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know
that EPREFIX cannot contain spaces though, hence I applied the fix as
committed. If the array approach works with the eclass, then that'll be
certainly cleaner.
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
2012-08-07 16:23 ` Michał Górny
@ 2012-08-07 16:28 ` Fabian Groffen
0 siblings, 0 replies; 5+ messages in thread
From: Fabian Groffen @ 2012-08-07 16:28 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On 07-08-2012 18:23:54 +0200, Michał Górny wrote:
> > Sorry, I don't understand the problem. Is it a general problem with
> > the single quote or a special FreeBSD problem?
>
> A general problem. It won't work unless it's eval-ed. And if it were,
> there will be more harm than you can possibly imagine.
It works fine under Linux, Solaris and Darwin. So I think you're
jumping to conclusions here too quickly.
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
2012-08-07 16:26 ` Fabian Groffen
@ 2012-08-08 21:04 ` vivo75
0 siblings, 0 replies; 5+ messages in thread
From: vivo75 @ 2012-08-08 21:04 UTC (permalink / raw
To: gentoo-dev
Il 07/08/2012 18:26, Fabian Groffen ha scritto:
> On 07-08-2012 18:03:14 +0200, Torsten Veller wrote:
>> * "Fabian Groffen (grobian)"<grobian@gentoo.org>:
>>> grobian 12/08/07 15:21:54
>>>
>>> Modified: ChangeLog
>>> Added: XML-Parser-2.410.0-r1.ebuild
>>> Log:
>>> Fix expat detection for FreeBSD that silently went unnoticed.
>> The following single quotes were dropped:
>>
>> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
>> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"
>>
>> Sorry, I don't understand the problem. Is it a general problem with
>> the single quote or a special FreeBSD problem?
> I've only observed it happening on FreeBSD indeed.
does this work?
myconf="\"EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)\"
\"EXPATINCPATH=${EPREFIX}/usr/include\""
and does thos work with spaces in EPREFIX, are they allowed in there at all?
myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
EXPATINCPATH=${EPREFIX}/usr/include"
>
>> I think we should convert all myconf strings to arrays:
>> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )
> I don't understand enough of the Makefile.PL thing to tell why the
> quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know
> that EPREFIX cannot contain spaces though, hence I applied the fix as
> committed. If the array approach works with the eclass, then that'll be
> certainly cleaner.
yep
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-08 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120807152154.99BEE2004B@flycatcher.gentoo.org>
2012-08-07 16:03 ` [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog Torsten Veller
2012-08-07 16:23 ` Michał Górny
2012-08-07 16:28 ` Fabian Groffen
2012-08-07 16:26 ` Fabian Groffen
2012-08-08 21:04 ` vivo75
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox