From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 64F74158013 for ; Mon, 11 Dec 2023 18:57:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 87C512BC03D; Mon, 11 Dec 2023 18:57:46 +0000 (UTC) Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5477D2BC02F for ; Mon, 11 Dec 2023 18:57:46 +0000 (UTC) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-1fadb9ac169so3301288fac.0 for ; Mon, 11 Dec 2023 10:57:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702321065; x=1702925865; darn=lists.gentoo.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XZDxhl33nQHtZu1HSMGNHVGfhLQkEN8QfmJEMPmaqdU=; b=SAMFEOSXNvhc/xG5Mnh7vujwGcpyheRcPqjnDmfobAepzAGWgWcH4/nA1IaJeIKSlL 4WcIDJVsaSUuIGfvpKxYtFhglUqZfdad4WyZOgUgoFKXs7hRKePXVmpT7IGx7uxeWjEo jadv7ye2nr5kQYalO0HdF7WvPDYMog0iacttyJkSqAOQU/tPbRk44YjypNXgq7bjabxA oBDIZLnWU555/9/vHCAIbm90I3AXNIjhmymEAWndYRInfRAqqOBNfwjUkdwnnPUupO6J Njywyf7LuKPcB3nULqE3ZQC/nhde2yDYHT5X11xNHG19l4ljWm6E9nzaICMo1qI3EL4k skUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702321065; x=1702925865; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XZDxhl33nQHtZu1HSMGNHVGfhLQkEN8QfmJEMPmaqdU=; b=JHIM6L5TLb55oRh6B29B0mfc3Onr+vGBc79BqefW2t08weBHiUQMRwQBvxC/QL7nnF eBsJEV9fH9dx9xTaqzxb86PkdxRV084fJTxz5KD0w8TtwKAVaF4wh4VLvtRH8FC5gSh7 ChRZGddQnAljx68wpiE9XUzjUzyUYKFb5BcTe9gUCueDBunYu5jVq3hfpW3keobAuwuG T5y48BdUUn46NrwtLm33D/RQEIU+dpkuAaVCpRPINcL6WNa51wnS84Fo/MsbYjp74KuR N4nY1bMY4UDxGqIDTmQQlZNV7xOkdc5+4PSV55+Zwmd8L3teSukQsLipDxzIpUZ5xFa6 CvAA== X-Gm-Message-State: AOJu0Yxtos83tcv2hhnCqfP6y5HL4WFwWQXg9ORecBfT7XY2u+rt+2B0 7xBge9EaJbR7ki7dF3jKU2GAwwdvFxg= X-Google-Smtp-Source: AGHT+IF5mXKsUZAQCA5Zr9hisHrK3oFui51SHrW28ksC6vWvLG8Dlammn+Tg9yFchJOYWoBV3rqD5Q== X-Received: by 2002:a05:6870:e8c9:b0:1fb:75a:6d30 with SMTP id r9-20020a056870e8c900b001fb075a6d30mr5873498oan.87.1702321064686; Mon, 11 Dec 2023 10:57:44 -0800 (PST) Received: from [192.168.1.89] (108-200-163-197.lightspeed.bcvloh.sbcglobal.net. [108.200.163.197]) by smtp.gmail.com with ESMTPSA id os25-20020a0568707d1900b001fb28cd0e9asm2593700oab.3.2023.12.11.10.57.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 10:57:44 -0800 (PST) Message-ID: <4c6f48a8-ba55-4ae4-b4fa-ebbaae95c155@gmail.com> Date: Mon, 11 Dec 2023 13:57:39 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR Content-Language: en-US To: gentoo-dev@lists.gentoo.org, =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= References: <20231202124443.244613-1-mgorny@gentoo.org> From: Eli Schwartz Autocrypt: addr=eschwartz93@gmail.com; keydata= xsFNBFcpfj0BEADkTcFAwHJmtXbR7WHu6qJ3c83ccZl4qjBsU//JEn9yTtfj8M2a3g+lpGAF C/8isGz9InmrqBn1BXQFwcySAkRYuromR5ZPH1HIsv21RTtJbo5wCs8GlvoRYsp5pE7JEIVC RsWixG5pFhinlssUxtm0szlrzfaKanohWDfj+2WuWh4doXJZtTQePCGpouSziButkwkgQMqE U+ubBiTtjF/f/oCyC6YMWx+5knaqNSWxjF52rXAngVD0YYAiJ7o0KOQhrC2RLF+l0x4hRikp QaZrqVL1CaP7gjceOlOZ/zdCOImAaha9ygZiJG652HCIPfsy7uypYwxoMEeldoTnsXbjJXuL fMwIp8dCVbKMhebXdCNIWCjNewusz3I4+JjOO+uPgA+YgHu8+A56tpJ7lmHw5C95XjheXt/N bo9HONG4oeILZ9pQxnx93ocZM6v0W+taoBbPzOLE0al7Oy5vmJwO/QkprDU/TkzPtrgiCKPV Ml/+smp5FXbOjp/Y5UVlFmj2aemDIVAv70RlewAytwQLdGHLv3Au81hq5xrX7JAopEkfhYJY g2+7s78C0VaMPXHw2XyLpj5uPBR2q8KihSaASfhGBH0IcxLd+lEq1+NHT2l/WlQVjRfXHZns k8giW8M12TJZvvm9rpXMAFk7zSmmojp1M/7+ImOTcDYvErW1iQARAQABzSRFbGkgU2Nod2Fy dHogPGVzY2h3YXJ0ejkzQGdtYWlsLmNvbT7CwZQEEwEKAD4CGwMFCwkIBwMFFQoJCAsFFgID AQACHgECF4AWIQS9J7B6XvRcKtr3DgSEgYpoGa9KmwUCYstIWwUJEUVkngAKCRCEgYpoGa9K m50AEACoEoXaBaVerjTGbezOHK8J+GWkDJQ8wetJJfHhBgDq/lypKF+1LmolXAkmJF29ShBx r9zr5n91E1xn4bX53X8NdVAf2r/dFMtzlu0jsl0UcZ6OllpkTBtWqbjNgAI+C/v/lbBVcCz+ irtrRfM/guLNaaUuZlh+Qtt4kdKygP64jhqRude/eD0tAVzXbnka0k2E40dNT8W23SPnbjJh gpZeGeufIf8xFddDdLaqZMuxjDcxqq1jcasPB8M57Vkt5NpTaIvCtO4ZWejoj9im+Onsdvfs 3mCHr1DcIEAYj36/2U8yXzpsdgFXD96WcLFRL3l4ELTAPua3MFNdty6Bf35Yli1Fby4yOnf8 5UQd4SRh1pYqBoBw7uEtY8qOJR+bvqo2XnTrR9HVYBZVrVhFe/CCSxOfm2ZxZn2bzMzoJZ5X jcMNGdkHVcutvgJOIUASnwSoJM4hoVdwRmGgrT1Mu18rkk05+NjElPmGcn9vFZXVddnqvuqd gf4di2xl0adpWgFFSfKeOBjNcPSQqNLjNcJTGVJ0lvlmGcYfyw020IoGu/bBEUpQA12i/4JE N5Qx1frWsvXQ+ioJkFsjydbpWqLR5xI44p1FWU2lwKT4QbtSkgx9sHOec+DIIarwxqDiMXR9 ZhG/Ue7+pXAVD/Zs/XtxXCZQBhl7keIXTmZKTccuYM7BTQRXKX49ARAAo1bWz1d7RvffuaX9 SAOqQEfeEHaRilIKpqU5+yuBSd7vLNF1QPb105cuMJtj0bHhQnqYlToNODAHn9Ug+Axgz3dT +s8j1/mizFLfgpHnWdNr7/a1lMPhmPqtoeEdUAd0bqX94xHedZBtlvhLAwoelNhatJkqbrWc voI9d3RMLA3tPrTxY6aeDTa+5LL8oHeZ04KXlWxQIqxXT+e0JEs+0V9viicYy/8i4DqfObtr jdNOV3cKCW3rmNTATlVmciGY8xHkwM77C67ibFyYOdoYo6IP7EUI1oTBZN1M2A23sSgUlAHP qPFwD38JPiBLYu5pIA3SwDaatTD/+BEdhsiIQsZaWsn0E98Bb0bHfukMvEYFEcwA//HXTVIN SGry/Tc9baIgD0hG8ImDCbR9RfXdz0uzelHypcKGnGB7FLtZ8Vw4swa06CXEGG0Oo5AfYRuU 2bQtFxH66xHEFSfgfpTy5nHTH9Ra1mTtpoDil6rMLq1q43w5XP7oEucZwdZa+hlj2M4I/i+I gcaU+Bd9bQMa2mmvmI7pOFMxCCvprY5fDaRY1v8rKWRg12bD4kYM3npR37rWkk+Zdj+w+XgS oCW0gNT2yHDDMq7H6qYUjyvaG8l0vhWb44rzQLBFfQv/Lc3QI4jUu6e7TbQui3cw5Qn0E+yu 4teV2fIVDbLB8wvRS/8AEQEAAcLBfAQYAQoAJgIbDBYhBL0nsHpe9Fwq2vcOBISBimgZr0qb BQJiy0j1BQkRRWU4AAoJEISBimgZr0qbjUwQAL+qByV+VpVmD3Guqym9uUX/gUmLdLar7ZrM Nr3RnDo/N0Dl2IZpm+eoNGlnBh2+q6bcZUWWoEtbOoy6XrlPnx3Cf+Bg4bFDNN4ibIQkYV2z cU9E1AWadCKUm1Z2eDqjc5TlLZiyUGQUh4kAW2Z3gFe1ffhyKarVExfTSxwE1ec5Q9cy6T29 iO3QjAD3v7R9EXZJIn/RRbsaWQSQLz+DVDZxjy2XcmTGLS3HMIqdYFHYAxUx7HLbCAhfIyD0 TDsMOutl3B2PWENYWmhO6E+USSwPokx461ePqcYG5haqnoUcXGQ2SGtLaoQ2iKGvGAe17xpQ yHK7NGSPWOEmYSJ1bRFJYKoe8+jtesoEY335hyQRn7RbMvTslVUvtVjRYu4FXOwPXT3NLbj8 v+in+Njm1UfuWvOZS695wepBGvDtMM3Ze+ZRB3S7zmo1/eKol1cQQ/abYlX+7TrUbxcQ+bAQ b8PeDaL4sAH77fE6m+3jsMb1CFbN3+LcaUxGV7ysh7kVYVqwhiRqnmF0E3I9z3nyZ9HQgwHt 1jmoa4lMiRDnkkOFdhoJ3vqmxHKW9XtxrUJlLQfTejUSooLFjNe6tvXgrTvrosGTpDZIIT0/ 8qKt4Nxg06u0jmnXMbbWwoPNWl9PfcPtNhjaycocCzfog5LI8N7HbRy+jHmArWAywaZVLrLe In-Reply-To: <20231202124443.244613-1-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 107376f5-9815-44e9-abaf-3d40f95c4258 X-Archives-Hash: 31e1a61fb68150bc95d0f7eec28af057 On 12/2/23 7:44 AM, Michał Górny wrote: > Update epytest to respect the modern NO_COLOR variable rather than > Portage's old NOCOLOR. Adjust it to correctly check whether it is set > at all rather than to a specific value, to match the behavior of pytest > itself. > > Signed-off-by: Michał Górny > --- > eclass/python-utils-r1.eclass | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass > index 394f64a5d139..da9cb820840f 100644 > --- a/eclass/python-utils-r1.eclass > +++ b/eclass/python-utils-r1.eclass > @@ -1336,15 +1336,8 @@ epytest() { > _python_check_EPYTHON > _python_check_occluded_packages > > - local color > - case ${NOCOLOR} in > - true|yes) > - color=no > - ;; > - *) > - color=yes > - ;; > - esac > + local color=yes > + [[ ${NO_COLOR} ]] && color=no [[ -v NO_COLOR ]] This is processed by the pytest code: ``` if "NO_COLOR" in os.environ: return False ``` > > local args=( > # verbose progress reporting and tracebacks -- Eli Schwartz