Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/python-openid: python-openid-2.2.4.ebuild

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/python-openid: python-openid-2.2.4.ebuild

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 825 bytes --]

2010-06-29 04:05:54 Jeremy Olexa napisał(a):
> On Mon, 28 Jun 2010 19:42:27 +0000 (UTC), "Arfrever Frehtes Taifersar
> Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> > arfrever    10/06/28 19:42:27
> > 
> >   Modified:             python-openid-2.2.4.ebuild
> >   Log:
> >   Fix dependencies.
> >   (Portage version: HEAD/cvs/Linux x86_64)
> 
> Is there any reason you are so non-verbose here? 'cvs log' or '$EDITOR
> ChangeLog' equally give us no information about your commit. You are
> making it hard on other devs in my opinion, I don't think intentionally,
> but can't you just use the ChangeLog more??

It was intermediate commit during my work on python-openid-2.2.5.ebuild.
python-openid-2.2.4.ebuild has been mentioned in ChangeLog in final commit.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/python-openid: python-openid-2.2.4.ebuild

[Sebastian Pipping]

Arfrever,


On 06/28/10 22:26, Arfrever Frehtes Taifersar Arahesis wrote:
>> Is there any reason you are so non-verbose here? 'cvs log' or '$EDITOR
>> ChangeLog' equally give us no information about your commit. You are
>> making it hard on other devs in my opinion, I don't think intentionally,
>> but can't you just use the ChangeLog more??
> 
> It was intermediate commit during my work on python-openid-2.2.5.ebuild.

Please take my vote on proper commit messages for any commit, including
intermediate ones.  Thanks!

Best,



Sebastian

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/python-openid: python-openid-2.2.4.ebuild

[Jeremy Olexa]

On Mon, 28 Jun 2010 19:42:27 +0000 (UTC), "Arfrever Frehtes Taifersar
Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> arfrever    10/06/28 19:42:27
> 
>   Modified:             python-openid-2.2.4.ebuild
>   Log:
>   Fix dependencies.
>   (Portage version: HEAD/cvs/Linux x86_64)

Is there any reason you are so non-verbose here? 'cvs log' or '$EDITOR
ChangeLog' equally give us no information about your commit. You are
making it hard on other devs in my opinion, I don't think intentionally,
but can't you just use the ChangeLog more?? At least, that is my small
request and I think others feel the same. If not, I will quietly go back
in my corner.

-Jeremy

> Index: python-openid-2.2.4.ebuild
> ===================================================================
> -EAPI="2"
> -
> -NEED_PYTHON="2.5"
> +EAPI="3"
> +PYTHON_DEPEND="2:2.5"
>  SUPPORT_PYTHON_ABIS="1"
> +RESTRICT_PYTHON_ABIS="2.4 3.*"
>  
>  inherit eutils distutils
>  
> @@ -22,7 +22,6 @@
>  	postgres? ( dev-python/psycopg )
>  	sqlite? ( || ( dev-lang/python[sqlite] >=dev-python/pysqlite-2 ) )"
>  DEPEND="${RDEPEND}"
> -RESTRICT_PYTHON_ABIS="3.*"

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/python-openid: python-openid-2.2.4.ebuild

[Jeremy Olexa]

On Mon, 28 Jun 2010 22:26:17 +0200, Arfrever Frehtes Taifersar Arahesis
<Arfrever@gentoo.org> wrote:
> 2010-06-29 04:05:54 Jeremy Olexa napisał(a):
>> On Mon, 28 Jun 2010 19:42:27 +0000 (UTC), "Arfrever Frehtes Taifersar
>> Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
>> > arfrever    10/06/28 19:42:27
>> >
>> >   Modified:             python-openid-2.2.4.ebuild
>> >   Log:
>> >   Fix dependencies.
>> >   (Portage version: HEAD/cvs/Linux x86_64)
>>
>> Is there any reason you are so non-verbose here? 'cvs log' or '$EDITOR
>> ChangeLog' equally give us no information about your commit. You are
>> making it hard on other devs in my opinion, I don't think intentionally,
>> but can't you just use the ChangeLog more??
> 
> It was intermediate commit during my work on python-openid-2.2.5.ebuild.
> python-openid-2.2.4.ebuild has been mentioned in ChangeLog in final commit.

You are correct - 2.2.4 IS mentioned in the ChangeLog during the
subsequent commit. So you think it is ok to hide the first commit under
a ChangeLog entry of "Version bump" ? I don't see the logic. My issue
with this is that other devs (or users) still don't know how or why the
dependancies got in the 2.2.5 version or what deps were fixed.

In this case, I would have committed a new 2.2.5 version with the
ChangeLog entry of: "Version bump, fix python dependancies that are
incorrect in the old" or somthing like that. This way commit #1 is not
hidden and placed under a false entry of commit #2.

-Jeremy