public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Samuli Suominen <ssuominen@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete
Date: Wed, 27 Jun 2012 22:12:34 +0300	[thread overview]
Message-ID: <4FEB5B22.5050401@gentoo.org> (raw)

The logic in prune_libtool_files is not perfect[1].

If you are updating ebuild for whatever reason and see `find` command to 
punt .la files, and replace it with prune_libtool_files then you also 
need to build the package (with "every" possible USE flag combination) 
to see if --all argument is also needed.

To clarify:

Use `prune_libtool_files --all` instead of plain `prune_libtool_files` 
if you don't test the package with the USE flags.

Not going to point anyone with a finger but the accident has already 
happened couple of times in tree :P

[1] http://bugs.gentoo.org/421197



             reply	other threads:[~2012-06-27 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 19:12 Samuli Suominen [this message]
2012-06-28  8:26 ` [gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete Michał Górny
2012-06-28 21:18   ` Pacho Ramos
2012-06-30  7:42     ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEB5B22.5050401@gentoo.org \
    --to=ssuominen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox