Re: [gentoo-dev] RFC: esethome

[Ian Stakenvicius <axs@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 13/06/12 04:51 PM, Mike Frysinger wrote:
> On Wednesday 13 June 2012 15:35:40 Ian Stakenvicius wrote:
>> --- user.eclass           [some timestamp] +++
>> user.eclass.esethome  [some other timestamp] @@ -388,3 +388,63
>> @@ }
>> 
>> fi + +# @FUNCTION: esethome
> 
> has to be inside the giant if block.  so put this above the "fi".
> 
>> +# @USAGE: <user> <homedir> +# @DESCRIPTION: +# Update the home
>> directory in a platform-agnostic way. +# Required parameters is
>> the username and the new home directory. +# Specify -1 if you
>> want to set home to the enewuser default +# of /dev/null. +# If
>> the new home directory does not exist, it is created. +# Any
>> previously existing home directory is NOT moved. +esethome() { +
>> _assert_pkg_ebuild_phase ${FUNCNAME} + +       # get the
>> username +       local euser=$1; shift +       if [[ -z ${euser}
>> ]] ; then +               eerror "No username specified !" +
>> die "Cannot call esethome without a username" +       fi + +
>> # lets see if the username already exists +       if [[ ! -n
>> $(egetent passwd "${euser}") ]] ; then
> 
> "! -n" -> "-z" -mike


So outside of syntax issues like above, anyone have any issues with my
adding this to user.eclass ?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iF4EAREIAAYFAk/bNaoACgkQ2ugaI38ACPAFRgEApwLkrsqSIW0nVK4l/dUTRzV9
ijEnbfa+BLc1skwfW4QA+gKgpmsz/K5VqXnVWyXocGqO98RYJL8lL3qm7k0Hs6uZ
=9i38
-----END PGP SIGNATURE-----