From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SaeTY-0007FS-UK for garchives@archives.gentoo.org; Sat, 02 Jun 2012 02:54:01 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E73BFE073E; Sat, 2 Jun 2012 02:53:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id C3CDCE064B for ; Sat, 2 Jun 2012 02:53:01 +0000 (UTC) Received: from [192.168.4.5] (blfd-4d083c5a.pool.mediaWays.net [77.8.60.90]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: hasufell) by smtp.gentoo.org (Postfix) with ESMTPSA id DA6D51B4009 for ; Sat, 2 Jun 2012 02:53:00 +0000 (UTC) Message-ID: <4FC97F62.2030206@gentoo.org> Date: Sat, 02 Jun 2012 04:50:10 +0200 From: hasufell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120502 Thunderbird/10.0.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass References: <4FB97D1D.9070004@gentoo.org> <4FBD892A.8030807@gentoo.org> <201206011849.39133.vapier@gentoo.org> In-Reply-To: <201206011849.39133.vapier@gentoo.org> X-Enigmail-Version: 1.3.5 Content-Type: multipart/mixed; boundary="------------060702030506090505000006" X-Archives-Salt: 39cbcf9c-5a2e-485e-a3bb-e30452c0a21c X-Archives-Hash: d1f51f55a0d7efb10c99a89eb778dfd0 This is a multi-part message in MIME format. --------------060702030506090505000006 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/02/2012 12:49 AM, Mike Frysinger wrote: > On Wednesday 23 May 2012 21:04:42 hasufell wrote: >> # @FUNCTION: _iconins >> # @DESCRIPTION: >> # function for use in doicon and newicon > > mark it @INTERNAL > >> if [[ -z $size ]] ; then > > ${size} > >> if [[ $function == doicon ]] ; then > > ${function} > >> if [[ $function == newicon ]] ; then > > ${function} > >> doicon() { >> local function=$FUNCNAME >> _iconins "$@" > > passing the funcname in this way is kind of ugly. you could do: > _iconins ${FUNCNAME} "$@" > > and then at the top of _iconins: > local funcname=$1; shift > > i guess if we all agree this complication is useful, then fix the nits and > let's merge it > -mike Yo, I hope this is it. Haven't seen many arguments against it as it is an optional feature anyway. Anyone got reservations left? --------------060702030506090505000006 Content-Type: text/plain; name="eutils.eclass.02jun" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="eutils.eclass.02jun" IyBASU5URVJOQUw6IF9pY29uaW5zCiMgQERFU0NSSVBUSU9OOgojIGZ1bmN0aW9uIGZvciB1 c2UgaW4gZG9pY29uIGFuZCBuZXdpY29uCl9pY29uaW5zKCkgewoJKAoJIyB3cmFwIHRoZSBl bnYgaGVyZSBzbyB0aGF0IHRoZSAnaW5zaW50bycgY2FsbAoJIyBkb2Vzbid0IGNvcnJ1cHQg dGhlIGVudiBvZiB0aGUgY2FsbGVyCglsb2NhbCBmdW5jbmFtZT0kMTsgc2hpZnQKCWxvY2Fs IHNpemUgZGlyCglsb2NhbCBjb250ZXh0PWFwcHMKCWxvY2FsIHRoZW1lPWhpY29sb3IKCgl3 aGlsZSBbWyAkIyAtZ3QgMCBdXSA7IGRvCgkJY2FzZSAkMSBpbgoJCS1zfC0tc2l6ZSkKCQkJ aWYgW1sgJHsyJSV4Kn14JHsyJSV4Kn0gPT0gIiQyIiBdXSA7IHRoZW4KCQkJCXNpemU9JHsy JSV4Kn0KCQkJZWxzZQoJCQkJc2l6ZT0kezJ9CgkJCWZpCgkJCWNhc2UgJHtzaXplfSBpbgoJ CQkxNnwyMnwyNHwzMnwzNnw0OHw2NHw3Mnw5NnwxMjh8MTkyfDI1NikKCQkJCXNpemU9JHtz aXplfXgke3NpemV9OzsKCQkJc2NhbGFibGUpCgkJCQk7OwoJCQkqKQoJCQkJZWVycm9yICIk e3NpemV9IGlzIGFuIHVuc3VwcG9ydGVkIGljb24gc2l6ZSEiCgkJCQlleGl0IDE7OwoJCQll c2FjCgkJCXNoaWZ0IDI7OwoJCS10fC0tdGhlbWUpCgkJCXRoZW1lPSR7Mn0KCQkJc2hpZnQg Mjs7CgkJLWN8LS1jb250ZXh0KQoJCQljb250ZXh0PSR7Mn0KCQkJc2hpZnQgMjs7CgkJKikK CQkJaWYgW1sgLXogJHtzaXplfSBdXSA7IHRoZW4KCQkJCWluc2ludG8gL3Vzci9zaGFyZS9w aXhtYXBzCgkJCWVsc2UKCQkJCWluc2ludG8gL3Vzci9zaGFyZS9pY29ucy8ke3RoZW1lfS8k e3NpemV9LyR7Y29udGV4dH0KCQkJZmkKCgkJCWlmIFtbICR7ZnVuY25hbWV9ID09IGRvaWNv biBdXSA7IHRoZW4KCQkJCWlmIFtbIC1mICQxIF1dIDsgdGhlbgoJCQkJCWRvaW5zICIkezF9 IgoJCQkJZWxpZiBbWyAtZCAkMSBdXSA7IHRoZW4KCQkJCQlzaG9wdCAtcyBudWxsZ2xvYgoJ CQkJCWRvaW5zICIkezF9Ii8qLntwbmcsc3ZnfQoJCQkJCXNob3B0IC11IG51bGxnbG9iCgkJ CQllbHNlCgkJCQkJZWVycm9yICIkezF9IGlzIG5vdCBhIHZhbGlkIGZpbGUvZGlyZWN0b3J5 ISIKCQkJCQlleGl0IDEKCQkJCWZpCgkJCWVsc2UKCQkJCWJyZWFrCgkJCWZpCgkJCXNoaWZ0 IDE7OwoJCWVzYWMKCWRvbmUKCWlmIFtbICR7ZnVuY25hbWV9ID09IG5ld2ljb24gXV0gOyB0 aGVuCgkJbmV3aW5zICIkQCIKCWZpCgkpIHx8IGRpZQp9CgojIEBGVU5DVElPTjogZG9pY29u CiMgQFVTQUdFOiBkb2ljb24gW29wdGlvbnNdIDxpY29ucz4KIyBAREVTQ1JJUFRJT046CiMg SW5zdGFsbCBpY29uIGludG8gdGhlIGljb24gZGlyZWN0b3J5IC91c3Ivc2hhcmUvaWNvbnMg b3IgaW50bwojIC91c3Ivc2hhcmUvcGl4bWFwcyBpZiAiLS1zaXplIiBpcyBub3Qgc2V0Lgoj IFRoaXMgaXMgdXNlZnVsIGluIGNvbmp1bmN0aW9uIHdpdGggY3JlYXRpbmcgZGVza3RvcC9t ZW51IGZpbGVzLgojCiMgQENPREUKIyAgb3B0aW9uczoKIyAgLXMsIC0tc2l6ZQojICAgICEh ISBtdXN0IHNwZWNpZnkgdG8gaW5zdGFsbCBpbnRvIC91c3Ivc2hhcmUvaWNvbnMvLi4uICEh IQojICAgIHNpemUgb2YgdGhlIGljb24sIGxpa2UgNDggb3IgNDh4NDgKIyAgICBzdXBwb3J0 ZWQgaWNvbiBzaXplcyBhcmU6CiMgICAgMTYgMjIgMjQgMzIgMzYgNDggNjQgNzIgOTYgMTI4 IDE5MiAyNTYgc2NhbGFibGUKIyAtYywgLS1jb250ZXh0CiMgICAgZGVmYXVsdHMgdG8gImFw cHMiCiMgLXQsIC0tdGhlbWUKIyAgICBkZWZhdWx0cyB0byAiaGljb2xvciIKIwojIGljb25z OiBsaXN0IG9mIGljb25zCiMgQENPREUKIwojIGV4YW1wbGUgMToKIyAgICBkb2ljb24gZm9v YmFyLnBuZyBmdXFiYXIuc3ZnCiMgICAgcmVzdWx0cyBpbjogaW5zaW50byAvdXNyL3NoYXJl L3BpeG1hcHMgOyBkb2lucyBmb29iYXIucG5nIGZ1cWJhci5zdmcKIwojIGV4YW1wbGUgMjoK IyAgICBkb2ljb24gLXMgNDggZm9vYmFyLnBuZyBmdXFiYXIucG5nCiMgICAgcmVzdWx0cyBp bjogaW5zaW50byAvdXNyL3NoYXJlL2ljb25zL2hpY29sb3IvNDh4NDgvYXBwcyA7IGRvaW5z IGZvb2Jhci5wbmcgZnVxYmFyLnN2ZwojICAgIApkb2ljb24oKSB7CglfaWNvbmlucyAke0ZV TkNOQU1FfSAiJEAiCn0KCiMgQEZVTkNUSU9OOiBuZXdpY29uCiMgQFVTQUdFOiBuZXdpY29u IFtvcHRpb25zXSA8aWNvbj4gPG5ld25hbWU+CiMgQERFU0NSSVBUSU9OOgojIExpa2UgZG9p Y29uLCBpbnN0YWxsIHRoZSBzcGVjaWZpZWQgaWNvbiBhcyBuZXduYW1lLgojCiMgZXhhbXBs ZSAxOgojICAgIG5ld2ljb24gZm9vYmFyLnBuZyBORVdOQU1FLnBuZwojICAgIHJlc3VsdHMg aW46IGluc2ludG8gL3Vzci9zaGFyZS9waXhtYXBzIDsgbmV3aW5zIGZvb2Jhci5wbmcgTkVX TkFNRS5wbmcKIwojIGV4YW1wbGUgMjoKIyAgICBuZXdpY29uIC1zIDQ4IGZvb2Jhci5wbmcg TkVXTkFNRS5wbmcgCiMgICAgcmVzdWx0cyBpbjogaW5zaW50byAvdXNyL3NoYXJlL2ljb25z L2hpY29sb3IvNDh4NDgvYXBwcyA7IG5ld2lucyBmb29iYXIucG5nIE5FV05BTUUucG5nCiMK bmV3aWNvbigpIHsKCV9pY29uaW5zICR7RlVOQ05BTUV9ICIkQCIKfQo= --------------060702030506090505000006--