public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Samuli Suominen <ssuominen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] enhancement for doicon/newicon in eutils.eclass
Date: Mon, 21 May 2012 20:32:31 +0300	[thread overview]
Message-ID: <4FBA7C2F.4090302@gentoo.org> (raw)
In-Reply-To: <20120521191439.181a8c2d@pomiocik.lan>

On 05/21/2012 08:14 PM, Michał Górny wrote:
> On Mon, 21 May 2012 01:24:13 +0200
> hasufell<hasufell@gentoo.org>  wrote:
>
>> I want support for installing icons into the appropriate directories
>> which are under /usr/share/icons/... and not just pixmaps.
>>
>> proposal attached + diff
>>
>> This should not break existing ebuilds. Tested a bit and open for
>> review now.
>
> I'd rather see a new function for that rather than making doicon()
> overcomplex.
>

Uh, please no. Doing something simple as installing icons shouldn't have 
multiple commands.

Should be easy enough to retain the old behavior, and add on top of that.

- Samuli



  reply	other threads:[~2012-05-21 17:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 23:24 [gentoo-dev] enhancement for doicon/newicon in eutils.eclass hasufell
2012-05-20 23:36 ` Alexis Ballier
2012-05-20 23:49   ` hasufell
2012-05-21  0:01     ` [gentoo-dev] " Jonathan Callen
2012-05-21  5:30       ` hasufell
2012-05-21 14:41         ` Mike Gilbert
2012-05-21 17:14 ` [gentoo-dev] " Michał Górny
2012-05-21 17:32   ` Samuli Suominen [this message]
2012-05-21 19:58   ` hasufell
2012-05-22  2:35     ` Mike Frysinger
2012-05-22  2:49 ` Mike Frysinger
2012-05-24  0:16   ` hasufell
2012-05-24  0:30     ` Mike Frysinger
2012-05-24  0:39       ` hasufell
2012-05-24  0:43       ` hasufell
2012-05-24  5:53         ` Michał Górny
2012-05-24  1:04 ` [gentoo-dev] " hasufell
2012-06-01 22:49   ` Mike Frysinger
2012-06-02  2:50     ` hasufell
2012-06-02  2:58       ` hasufell
2012-06-02  4:48       ` Mike Frysinger
2012-06-02 14:54         ` hasufell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBA7C2F.4090302@gentoo.org \
    --to=ssuominen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox