From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-51772-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1SWLGC-0003lg-TR
	for garchives@archives.gentoo.org; Mon, 21 May 2012 05:34:25 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 9CA18E05F9;
	Mon, 21 May 2012 05:34:06 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 274E5E096A
	for <gentoo-dev@lists.gentoo.org>; Mon, 21 May 2012 05:33:13 +0000 (UTC)
Received: from [192.168.4.5] (blfd-5d822d59.pool.mediaWays.net [93.130.45.89])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: hasufell)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 3018C1B400C
	for <gentoo-dev@lists.gentoo.org>; Mon, 21 May 2012 05:33:11 +0000 (UTC)
Message-ID: <4FB9D305.3080809@gentoo.org>
Date: Mon, 21 May 2012 07:30:45 +0200
From: hasufell <hasufell@gentoo.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120502 Thunderbird/10.0.4
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass
References: <4FB97D1D.9070004@gentoo.org> <20120520193625.6c8b2959@gentoo.org> <4FB98309.7030900@gentoo.org> <4FB985E9.3030107@gentoo.org>
In-Reply-To: <4FB985E9.3030107@gentoo.org>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 098624e2-a447-4d0f-b476-a450c2ba7fd7
X-Archives-Hash: 8c58b1025f5ed02b84cb75180329a811

On 05/21/2012 02:01 AM, Jonathan Callen wrote:
> On 05/20/2012 07:49 PM, hasufell wrote:
>> On 05/21/2012 01:36 AM, Alexis Ballier wrote:
>>> On Mon, 21 May 2012 01:24:13 +0200 hasufell
>>> <hasufell@gentoo.org> wrote:
>>> 
>>>> I want support for installing icons into the appropriate 
>>>> directories which are under /usr/share/icons/... and not
>>>> just pixmaps.
>>>> 
>>>> proposal attached + diff
>>>> 
>>>> This should not break existing ebuilds. Tested a bit and
>>>> open for review now.
>>> 
>>> maybe i missed something but cant you just make doicon a
>>> newicon wrapper and remove all that code duplication ?
>>> 
> 
>> I don't see how. "doicon" supports installing multiple icons
>> with one command, as well as directories. That does not work for 
>> "newicon".
> 
> 
> 
> Normally, new* is a wrapper for do* that does something like:
> 
> newfoo() { # argument checking omitted... cp -P "${1}" "${T}/${2}" 
> dofoo "${T}/${2}" }
> 
> 

That does not use "newins" like the old function. Why would I want to
change that?