From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SOu3n-0005gC-CX for garchives@archives.gentoo.org; Mon, 30 Apr 2012 17:06:51 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D063CE0B53; Mon, 30 Apr 2012 17:06:37 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 57DD1E094E for ; Mon, 30 Apr 2012 17:05:57 +0000 (UTC) Received: from [192.168.26.5] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id D37D01B4045 for ; Mon, 30 Apr 2012 17:05:56 +0000 (UTC) Message-ID: <4F9EC673.4090806@gentoo.org> Date: Mon, 30 Apr 2012 10:05:55 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:11.0) Gecko/20120404 Thunderbird/11.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] About validate_desktop_entries in eutils.eclass References: <1334483990.2557.6.camel@belkin4> <20120415160254.4849799a@pomiocik.lan> <1334499131.2557.12.camel@belkin4> <4F9D7013.9090309@gentoo.org> In-Reply-To: <4F9D7013.9090309@gentoo.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 48c14a4e-5628-41a2-8941-bef07fbe7d2a X-Archives-Hash: 62a9faf5aedb3e79b44f6f2e6462a9f7 On 04/29/2012 09:45 AM, Petteri R=C3=A4ty wrote: > On 15.04.2012 17:12, Pacho Ramos wrote: >> El dom, 15-04-2012 a las 16:02 +0200, Micha=C5=82 G=C3=B3rny escribi=C3= =B3: >>> On Sun, 15 Apr 2012 11:59:50 +0200 >>> Pacho Ramos wrote: >>> >>>> I am unsure about validate_desktop_entries() utility. It's currently >>>> provided by eutils.eclass and only called by net-firewall/fwbuilder. >>>> Shouldn't this be moved to a "qa" check? Current way is pretty usele= ss >>>> as it's not used by most of packages, and calling it from a lot of >>>> eclasses/ebuilds doesn't sound me like a good idea. >>>> >>>> What do you think? >>> >>> Agreed. It should be in repoman. >>> >> >> The check needs to be run over desktop file going to be installed, not >> sure how repoman can handle it, it looked to me more like a emerge job >> (like is done with other qa checks run before installation) >=20 > There's actually already code in repoman that runs > desktop-file-validate. It of course only works for installed packages. > Someone could make it run runtime too. The repoman code works on $FILESDIR. It looks like we also want to run it after src_install. Also, it looks like we might need to handle a special case for Konqueror Service Menus: https://bugs.gentoo.org/show_bug.cgi?id=3D414125 --=20 Thanks, Zac