From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SMCHV-0006oq-HI for garchives@archives.gentoo.org; Mon, 23 Apr 2012 05:57:49 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C36EAE0BB4; Mon, 23 Apr 2012 05:57:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B47FBE0B76 for ; Mon, 23 Apr 2012 05:56:53 +0000 (UTC) Received: from [192.168.26.2] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 30CEA1B4039 for ; Mon, 23 Apr 2012 05:56:53 +0000 (UTC) Message-ID: <4F94EF23.9070101@gentoo.org> Date: Sun, 22 Apr 2012 22:56:51 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120404 Thunderbird/11.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Making user patches globally available References: <20120415021641.1858ffde@gentoo.org> <4F8A885C.3050508@gentoo.org> <20120415030326.0355ecf2@gentoo.org> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: adf3d113-1813-47de-9311-2463af610b13 X-Archives-Hash: 010b87ffd26b8d8ca5dbd4a734091e71 On 04/22/2012 10:04 PM, Steven J Long wrote: > It seems there's two major cases, with autotools or without. In either case, > epatch_user should be called after Gentoo patches have been applied. > > Why not make epatch_user set a variable to indicate that patches have been > applied, and only apply the patches on the first call? > > Then eautoreconf could call it before calling autoconf (and the ebuild > wouldn't need to worry about it.) And any custom src_prepare function could > call it when needed, if it needed to be done during the phase, and not > after. > > After src_prepare, the PM could just call it unconditionally, since it will > not apply the patches again, if it's already been called by the ebuild. > > Does that make sense? Yeah, sounds roughly equivalent to Ciaran's suggested "apply_user_patches_here" approach [1], except that Ciaran suggested to make it an error if src_prepare doesn't call apply_user_patches_here (so people don't forget to call it when they should). [1] http://archives.gentoo.org/gentoo-dev/msg_c228be85e0c4e577ad194e6004d59062.xml -- Thanks, Zac