[gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs

[gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs

[Anthony G. Basile]

Hi everyone,

pax-utils.eclass generates a lot of log messages when marking a large 
number of files, for example icedtea-bin.  These messages are not that 
useful, so I propose downgrading all elog's to einfo's to avoid 
flooding.  See bug #407503.  If there are no objections, I'll commit the 
following in a few days:

--- pax-utils.eclass.orig    2012-04-03 09:29:41.000000000 -0400
+++ pax-utils.eclass    2012-04-03 09:30:49.000000000 -0400
@@ -58,8 +58,8 @@
      # Try paxctl, then scanelf.  paxctl is preferred.
      if type -p paxctl>  /dev/null&&  has PT ${PAX_MARKINGS}; then
          # Try paxctl, the upstream supported tool.
-        elog "PT PaX marking -${flags}"
-        _pax_list_files elog "$@"
+        einfo "PT PaX marking -${flags}"
+        _pax_list_files einfo "$@"
          for f in "$@"; do
              # First, try modifying the existing PAX_FLAGS header
              paxctl -q${flags} "${f}"&&  continue
@@ -91,8 +91,8 @@
      elif type -p scanelf>  /dev/null&&  [[ ${PAX_MARKINGS} != "none" ]]; then
          # Try scanelf, the Gentoo swiss-army knife ELF utility
          # Currently this sets PT if it can, no option to control what it does.
-        elog "Fallback PaX marking -${flags}"
-        _pax_list_files elog "$@"
+        einfo "Fallback PaX marking -${flags}"
+        _pax_list_files einfo "$@"
          scanelf -Xxz ${flags} "$@"
      elif [[ ${PAX_MARKINGS} != "none" ]]; then
          # Out of options!



-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : blueness@gentoo.org
GnuPG FP  : 8040 5A4D 8709 21B1 1A88  33CE 979C AF40 D045 5535
GnuPG ID  : D0455535

Re: [gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs

[Anthony G. Basile]

Okay no feedback.  I'm assuming no one had any issues.  I'm committing.

On 04/03/2012 09:55 AM, Anthony G. Basile wrote:
> Hi everyone,
>
> pax-utils.eclass generates a lot of log messages when marking a large 
> number of files, for example icedtea-bin.  These messages are not that 
> useful, so I propose downgrading all elog's to einfo's to avoid 
> flooding.  See bug #407503.  If there are no objections, I'll commit 
> the following in a few days:
>
> --- pax-utils.eclass.orig    2012-04-03 09:29:41.000000000 -0400
> +++ pax-utils.eclass    2012-04-03 09:30:49.000000000 -0400
> @@ -58,8 +58,8 @@
>      # Try paxctl, then scanelf.  paxctl is preferred.
>      if type -p paxctl>  /dev/null&&  has PT ${PAX_MARKINGS}; then
>          # Try paxctl, the upstream supported tool.
> -        elog "PT PaX marking -${flags}"
> -        _pax_list_files elog "$@"
> +        einfo "PT PaX marking -${flags}"
> +        _pax_list_files einfo "$@"
>          for f in "$@"; do
>              # First, try modifying the existing PAX_FLAGS header
>              paxctl -q${flags} "${f}"&&  continue
> @@ -91,8 +91,8 @@
>      elif type -p scanelf>  /dev/null&&  [[ ${PAX_MARKINGS} != "none" 
> ]]; then
>          # Try scanelf, the Gentoo swiss-army knife ELF utility
>          # Currently this sets PT if it can, no option to control what 
> it does.
> -        elog "Fallback PaX marking -${flags}"
> -        _pax_list_files elog "$@"
> +        einfo "Fallback PaX marking -${flags}"
> +        _pax_list_files einfo "$@"
>          scanelf -Xxz ${flags} "$@"
>      elif [[ ${PAX_MARKINGS} != "none" ]]; then
>          # Out of options!
>
>
>


-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : blueness@gentoo.org
GnuPG FP  : 8040 5A4D 8709 21B1 1A88  33CE 979C AF40 D045 5535
GnuPG ID  : D0455535