[gentoo-dev] RFC: Adding CCASFLAGS to filter-flags() in flag-o-matic.eclass

[gentoo-dev] RFC: Adding CCASFLAGS to filter-flags() in flag-o-matic.eclass

[Anthony G. Basile]

Hi everyone,

An issue came up with valgrind on the new multilib-portage which adds 
CFLAGS_$target_abi to $CFLAGS [1].  Valgrind fails to compile when -m64 
is added because it needs to set its own abi flags.  I tried to 
filter-flags() it out; however, the -m64 flag also make it into 
CCASFLAGS [2] which filter-flags() does touch.  I see no reason not to 
add CCASFLAGS to the list of flags filtered out by filter-flags(), so I 
propose the following patch to flag-o-matic.eclass.  Possible badness?

--- flag-o-matic.eclass.orig    2012-02-21 12:38:37.000000000 -0500
+++ flag-o-matic.eclass    2012-02-21 12:39:22.000000000 -0500
@@ -17,7 +17,7 @@

  # Return all the flag variables that our high level funcs operate on.
  all-flag-vars() {
-    echo {C,CPP,CXX,F,FC,LD}FLAGS
+    echo {C,CPP,CXX,CCAS,F,FC,LD}FLAGS
  }

  # {C,CXX,F,FC}FLAGS that we allow in strip-flags
@@ -101,7 +101,7 @@
  # @FUNCTION: filter-flags
  # @USAGE: <flags>
  # @DESCRIPTION:
-# Remove particular <flags> from {C,CPP,CXX,F,FC,LD}FLAGS.  Accepts 
shell globs.
+# Remove particular <flags> from {C,CPP,CXX,CCAS,F,FC,LD}FLAGS.  
Accepts shell globs.
  filter-flags() {
      _filter-hardened "$@"
      local v



Ref.
[1] https://bugs.gentoo.org/show_bug.cgi?id=398825
[2] http://www.delorie.com/gnu/docs/automake/automake_50.html

-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : blueness@gentoo.org
GnuPG FP  : 8040 5A4D 8709 21B1 1A88  33CE 979C AF40 D045 5535
GnuPG ID  : D0455535

Re: [gentoo-dev] RFC: Adding CCASFLAGS to filter-flags() in flag-o-matic.eclass

[Anthony G. Basile]

Okay, looks like there are no objections.  I'll commit this tomorrow.

On 02/21/2012 12:42 PM, Anthony G. Basile wrote:
> Hi everyone,
>
> An issue came up with valgrind on the new multilib-portage which adds 
> CFLAGS_$target_abi to $CFLAGS [1].  Valgrind fails to compile when 
> -m64 is added because it needs to set its own abi flags.  I tried to 
> filter-flags() it out; however, the -m64 flag also make it into 
> CCASFLAGS [2] which filter-flags() does touch.  I see no reason not to 
> add CCASFLAGS to the list of flags filtered out by filter-flags(), so 
> I propose the following patch to flag-o-matic.eclass.  Possible badness?
>
> --- flag-o-matic.eclass.orig    2012-02-21 12:38:37.000000000 -0500
> +++ flag-o-matic.eclass    2012-02-21 12:39:22.000000000 -0500
> @@ -17,7 +17,7 @@
>
>  # Return all the flag variables that our high level funcs operate on.
>  all-flag-vars() {
> -    echo {C,CPP,CXX,F,FC,LD}FLAGS
> +    echo {C,CPP,CXX,CCAS,F,FC,LD}FLAGS
>  }
>
>  # {C,CXX,F,FC}FLAGS that we allow in strip-flags
> @@ -101,7 +101,7 @@
>  # @FUNCTION: filter-flags
>  # @USAGE: <flags>
>  # @DESCRIPTION:
> -# Remove particular <flags> from {C,CPP,CXX,F,FC,LD}FLAGS.  Accepts 
> shell globs.
> +# Remove particular <flags> from {C,CPP,CXX,CCAS,F,FC,LD}FLAGS.  
> Accepts shell globs.
>  filter-flags() {
>      _filter-hardened "$@"
>      local v
>
>
>
> Ref.
> [1] https://bugs.gentoo.org/show_bug.cgi?id=398825
> [2] http://www.delorie.com/gnu/docs/automake/automake_50.html
>


-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : blueness@gentoo.org
GnuPG FP  : 8040 5A4D 8709 21B1 1A88  33CE 979C AF40 D045 5535
GnuPG ID  : D0455535