From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RbWGY-0003EV-Hz for garchives@archives.gentoo.org; Fri, 16 Dec 2011 11:47:54 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B404A21C0C2; Fri, 16 Dec 2011 11:47:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 83BAD21C0BE for ; Fri, 16 Dec 2011 11:46:27 +0000 (UTC) Received: from ics6165.ics.kfa-juelich.de (ics6165.ics.kfa-juelich.de [134.94.118.166]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id 52F841B40B3; Fri, 16 Dec 2011 11:46:26 +0000 (UTC) Message-ID: <4EEB2F8F.2000504@gentoo.org> Date: Fri, 16 Dec 2011 12:46:23 +0100 From: justin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] making the stable tree more up-to-date References: <4ECA0EA3.8020407@gentoo.org> <1769026.9R6ACMvGeL@devil> <4EEB2715.5060806@gentoo.org> <2952499.vjcSCuKqgc@devil> In-Reply-To: <2952499.vjcSCuKqgc@devil> X-Enigmail-Version: 1.3.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig3C01643DFB064692D9681519" X-Archives-Salt: ca4d3736-c790-4987-a2d9-4f42bb5ee008 X-Archives-Hash: 39eab3348fd7e5a8c13e854e30a37e42 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3C01643DFB064692D9681519 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/16/11 12:21 PM, Agostino Sarubbo wrote: > On Friday 16 December 2011 06:10:13 Anthony G. Basile wrote: >> Does your script do any checking on the quality of the ebuild, eg that= >> it respects C/LDFLAGS. If so, that's useful and would help package >> maintainers to better prepare their ebuilds for stabilization. > Unfortunately no.=20 >=20 > For LDFLAGS there is a QA warning and is enough visible > For CFLAGS I see with the naked eye a bit of build log > My script at "end of work" just runs repoman full and cat entire ebuild= ( so,=20 > imho, should be a tasks already done by maintainers). > Finally, I take a look at the ebuild to see if there are issue(s) >=20 > This is all. >=20 >> And congrats on making dev > Thanks ;) >=20 >=20 > Regards > Agostino You can use the post* hooks for that. For FLAGS mixing I am using CFLAGS and CXXFLAGS specific warning flags during compilation and grep for the gcc mixing warning in the build log. Probably similar things can be done for other problematic points. There was also a more sophisticated approach Diego blogged about. For respecting C/CXXFLAGS there was something Donnie suggested long ago. If you use -frecord-gcc-switches you are able to read the used LFGAS with eu-readelf. Probably someone likes to put this together in a guideline how to check a package correctly. justin --------------enig3C01643DFB064692D9681519 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEAREKAAYFAk7rL48ACgkQgAnW8HDreRZFdgCgsZafMwlOJ/0SrtFrYbo5cpxa KqcAnR77ofgUEFi/Fwqlga9P6//RUzSO =oqeq -----END PGP SIGNATURE----- --------------enig3C01643DFB064692D9681519--