From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RPefs-0002r9-7d for garchives@archives.gentoo.org; Sun, 13 Nov 2011 18:21:00 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 73FE021C1A9; Sun, 13 Nov 2011 18:20:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 2DAAA21C043 for ; Sun, 13 Nov 2011 18:20:26 +0000 (UTC) Received: from [192.168.168.169] (dyn-199-173-dsl.vsp.fi [83.146.199.173]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ssuominen) by smtp.gentoo.org (Postfix) with ESMTPSA id 3FBD31B4013; Sun, 13 Nov 2011 18:20:24 +0000 (UTC) Message-ID: <4EC00A15.6060309@gentoo.org> Date: Sun, 13 Nov 2011 20:19:01 +0200 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111111 Thunderbird/8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org, xmw@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libexif: ChangeLog libexif-0.6.20.ebuild References: <20111113180716.E5E082004B@flycatcher.gentoo.org> In-Reply-To: <20111113180716.E5E082004B@flycatcher.gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 90541a1d-088a-41ed-b3e7-33be1e3111b3 X-Archives-Hash: 647793374632fee21a67e671f59d9060 On 11/13/2011 08:07 PM, Michael Weber (xmw) wrote: > xmw 11/11/13 18:07:16 > > Modified: ChangeLog libexif-0.6.20.ebuild > Log: > remove -g from FLAGS, as pointed out by Agostino Sarubbo (bug 390249) > @@ -22,7 +22,11 @@ > > src_prepare() { > epatch "${FILESDIR}"/${PN}-0.6.13-pkgconfig.patch > - elibtoolize # FreeBSD .so version > + #elibtoolize # FreeBSD .so version > + sed -e '/FLAGS=/s:-g::g' \ > + -e '/FLAGS=/s:-Wall::g' \ > + -i configure.ac > + eautoreconf > } removing compile warning flags is not allowed, thus hiding also Portage's QA messages. restore -Wall. and running eautoreconf just to remove -g from configure is too heavy. just sed the configure directly. > > src_configure() { > @@ -38,5 +42,4 @@ > emake DESTDIR="${D}" install || die > find "${D}" -name '*.la' -exec rm -f {} + > rm -f "${D}"usr/share/doc/${PF}/{ABOUT-NLS,COPYING} > - prepalldocs > } the prepalldocs was still used because the ebuild is not EAPI=4. restore it or upgrade the EAPI.