[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libexif: ChangeLog libexif-0.6.20.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libexif: ChangeLog libexif-0.6.20.ebuild

[Samuli Suominen]

On 11/13/2011 08:07 PM, Michael Weber (xmw) wrote:
> xmw         11/11/13 18:07:16
> 
>   Modified:             ChangeLog libexif-0.6.20.ebuild
>   Log:
>   remove -g from FLAGS, as pointed out by Agostino Sarubbo (bug 390249)
> @@ -22,7 +22,11 @@
>  
>  src_prepare() {
>  	epatch "${FILESDIR}"/${PN}-0.6.13-pkgconfig.patch
> -	elibtoolize # FreeBSD .so version
> +	#elibtoolize # FreeBSD .so version
> +	sed -e '/FLAGS=/s:-g::g' \
> +		-e '/FLAGS=/s:-Wall::g' \
> +		-i configure.ac
> +	eautoreconf
>  }

removing compile warning flags is not allowed, thus hiding also
Portage's QA messages. restore -Wall.

and running eautoreconf just to remove -g from configure is too heavy.
just sed the configure directly.

>  
>  src_configure() {
> @@ -38,5 +42,4 @@
>  	emake DESTDIR="${D}" install || die
>  	find "${D}" -name '*.la' -exec rm -f {} +
>  	rm -f "${D}"usr/share/doc/${PF}/{ABOUT-NLS,COPYING}
> -	prepalldocs
>  }

the prepalldocs was still used because the ebuild is not EAPI=4. restore
it or upgrade the EAPI.