From: Samuli Suominen <ssuominen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] elibtoolize/eautoreconf interactions and lazy eclasses/ebuilds
Date: Sun, 13 Nov 2011 19:45:50 +0200 [thread overview]
Message-ID: <4EC0024E.2030208@gentoo.org> (raw)
In-Reply-To: <201111131237.50507.vapier@gentoo.org>
On 11/13/2011 07:37 PM, Mike Frysinger wrote:
> it seems we have some cases where eclasses/ebuilds interact poorly. for
> example, if an eclass runs eautoreconf or elibtoolize, and then the ebuild
> does some stuff where it ends up running eautoreconf, subsequent elibtoolize
> calls are skipped.
>
> this means that the work done by the earlier elibtoolize call was all for
> naught, as eautoreconf blows all of its work away be regenerating the files
> elibtoolize patched. and when eautoreconf attempts to run elibtoolize itself,
> we don't get all the fun patches since elibtoolize detected it was run
> already.
>
> rather than have this continue to silently ignore the issue, i'm thinking of
> making these changes:
> - elibtoolize now has a --force flag
> - eautoreconf always calls elibtoolize with --force
> - if elibtoolize detects a previous run with --force, it warns, but runs
> this way we complain, but at least we continue to work
>
> the prefix guys first brought this up here:
> https://bugs.gentoo.org/232820
> but i've hit this since with cross-compiling Linux targets:
> - pygobject ebuild inherits gnome2 eclass
> - pygobject's src_prepare first calls gnome2_src_prepare
> - gnome2_src_prepare always calls elibtoolize (which normally is good)
> - pygobject's src_prepare applies patches and then calls eautoreconf
> - eautoreconf regens all files that where patched earlier
> - eautoreconf's call to elibtoolize is skipped
> - builds fail which need those elibtoolize patches
> -mike
also a bug in those ebuilds then, since gnome2_src_prepare() should
always be the last call/command in src_prepare()
next prev parent reply other threads:[~2011-11-13 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 17:37 [gentoo-dev] elibtoolize/eautoreconf interactions and lazy eclasses/ebuilds Mike Frysinger
2011-11-13 17:45 ` Samuli Suominen [this message]
2011-11-13 17:58 ` Nirbheek Chauhan
2011-11-13 18:03 ` Mike Frysinger
2011-11-14 17:09 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC0024E.2030208@gentoo.org \
--to=ssuominen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox