public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: justin <jlec@gentoo.org>
To: Samuli Suominen <ssuominen@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild
Date: Sat, 12 Nov 2011 12:56:44 +0100	[thread overview]
Message-ID: <4EBE5EFC.4000702@gentoo.org> (raw)
In-Reply-To: <4EBE4993.3040803@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]

On 11/12/11 11:25 AM, Samuli Suominen wrote:
> On 11/12/2011 12:21 PM, Justin Lecher (jlec) wrote:
>> jlec        11/11/12 10:21:37
>>
>>   Modified:             metadata.xml ChangeLog
>>                         ghostscript-gpl-9.04-r4.ebuild
>>   Log:
>>   Fixed slotting for media-libs/tiff
>>   
>>   (Portage version: 2.2.0_alpha73/cvs/Linux x86_64)
>>
>> Revision  Changes    Path
>> 1.3                  app-text/ghostscript-gpl/metadata.xml
>>
>> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3&view=markup
>> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3&content-type=text/plain
>> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?r1=1.2&r2=1.3
>>
>> Index: metadata.xml
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/app-text/ghostscript-gpl/metadata.xml,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- metadata.xml	2 Jun 2011 09:59:25 -0000	1.2
>> +++ metadata.xml	12 Nov 2011 10:21:37 -0000	1.3
>> @@ -1,8 +1,8 @@
>>  <?xml version="1.0" encoding="UTF-8"?>
>>  <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>>  <pkgmetadata>
>> -<herd>printing</herd>
>> -  <use>
>> -    <flag name="bindist">Disable dejavu support for binary distribution because of licensing issue</flag>
>> -  </use>
>> +	<herd>printing</herd>
>> +	<use>
>> +		<flag name="bindist">Disable dejavu support for binary distribution because of licensing issue</flag>
>> +	</use>
>>  </pkgmetadata>
> 
> I wonder what that has to do with "Fixed slotting for media-libs/tiff"?
> 

This means, we better should use media-libs/tiff:0 to avoid problem if
tkimg is installed. I added :0 to the tiff dep.

> Do we have a guideline or policy on using 2 spaces vs. tabs in .xml
> files and gentoo-x86? Just asking because I prefer 2 spaces over tabs.

I asked and as far as I can remember, there was a "do what you like"
answer. Especially older devs didn't like to be forced to anything here.
Why I changed it? Not directly by purpose. I am trying to fix formating
using xmlstartlet prior to commit, as I found that many metadata.xml do
not follow a clear rule. And xml formatting is a quite straight thing,
so I didn't thought people don't like it.

justin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  reply	other threads:[~2011-11-12 11:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111112102137.79A102004B@flycatcher.gentoo.org>
2011-11-12 10:25 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild Samuli Suominen
2011-11-12 11:56   ` justin [this message]
2011-11-12 12:01     ` justin
2011-11-12 15:17       ` Jorge Manuel B. S. Vicetto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBE5EFC.4000702@gentoo.org \
    --to=jlec@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=ssuominen@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox