From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RMLid-00017o-D8 for garchives@archives.gentoo.org; Fri, 04 Nov 2011 15:30:11 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D42F421C043; Fri, 4 Nov 2011 15:30:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 7B7B721C02A for ; Fri, 4 Nov 2011 15:29:26 +0000 (UTC) Received: from [192.168.1.131] (CPE002401f30b73-CM001cea3ddad8.cpe.net.cable.rogers.com [99.224.72.201]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: axs) by smtp.gentoo.org (Postfix) with ESMTPSA id C56901B4003 for ; Fri, 4 Nov 2011 15:29:25 +0000 (UTC) Message-ID: <4EB404C4.2050602@gentoo.org> Date: Fri, 04 Nov 2011 11:29:08 -0400 From: Ian Stakenvicius User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110920 Lightning/1.0b3pre Mnenhy/0.8.2 Thunderbird/3.1.12 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel References: <4EB3E1A2.6040702@gentoo.org> <4EB3FAD6.4080203@gentoo.org> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: f5d4ec3c-6505-487f-a4ca-d1969d61af87 X-Archives-Hash: 1f0f07c07708fd75c107e1d32e06c4e8 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 04/11/11 11:11 AM, Fabio Erculiani wrote: > On Fri, Nov 4, 2011 at 3:46 PM, Mike Gilbert wrote: >> >> It is good that we warn users about this when they install the package, >> but I don't think the ebuild should die. > > I've always found ebuilds dying at kernel config checks really annoying. > Checking kernel features at build time (if we die) is broken and > should be banned IMO: > > 1) in case of packages not needing kernel headers for building (but > just checking for a feature) > a) this breaks the compilation inside chroots on build servers where > the goal is to just build the package (hint: binpkgs) > b) it is anyway unable to reliably check if the feature is actually > available or not (/proc/config.gz might be unavailable, as well as > kernel sources or headers) As i think has already been mentioned, when building binpkgs or building for other systems, since the idea here is to ensure build-time requirements are met, things should be OK as long as you have a configured kernel for the target in place as well. And you probably should; if you're building packages for target systems you might as well configure and/or build their kernels too. Also as was mentioned, /proc/config.gz would never be appropriate in these cases since the running kernel probably has nothing to do with the target system's kernel. > > 2) in case of packages needing kernel headers (or sources) for building > a) doing the check in pkg_setup() breaks binpkgs support (the check > becomes part of a build time task, and not install time) .. so you're recommending the check be moved to pkg_preinst() ? Or perhaps duplicated into both pkg_setup/pkg_pretend and pkg_preinst ? That would be doable, wouldn't it? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iF4EAREIAAYFAk60BMQACgkQAJxUfCtlWe17qwEAhh2udNzptIJZHeEyh8DJhTj3 HLbC/ZpIJUQTbpHueOEBAITcA3DasGAQIdSWGvn7E2xwYMFTS+U0UyDWJCesv5xR =U+gT -----END PGP SIGNATURE-----