From: Ian Stakenvicius <axs@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel
Date: Fri, 04 Nov 2011 11:29:08 -0400 [thread overview]
Message-ID: <4EB404C4.2050602@gentoo.org> (raw)
In-Reply-To: <CAN3Atvoz5d5JLUGbnaL9mQbhqNjBxOh2xdUfN6zZ_t0UQW60cQ@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 04/11/11 11:11 AM, Fabio Erculiani wrote:
> On Fri, Nov 4, 2011 at 3:46 PM, Mike Gilbert <floppym@gentoo.org> wrote:
>>
>> It is good that we warn users about this when they install the package,
>> but I don't think the ebuild should die.
>
> I've always found ebuilds dying at kernel config checks really annoying.
> Checking kernel features at build time (if we die) is broken and
> should be banned IMO:
>
> 1) in case of packages not needing kernel headers for building (but
> just checking for a feature)
> a) this breaks the compilation inside chroots on build servers where
> the goal is to just build the package (hint: binpkgs)
> b) it is anyway unable to reliably check if the feature is actually
> available or not (/proc/config.gz might be unavailable, as well as
> kernel sources or headers)
As i think has already been mentioned, when building binpkgs or building
for other systems, since the idea here is to ensure build-time
requirements are met, things should be OK as long as you have a
configured kernel for the target in place as well. And you probably
should; if you're building packages for target systems you might as well
configure and/or build their kernels too.
Also as was mentioned, /proc/config.gz would never be appropriate in
these cases since the running kernel probably has nothing to do with the
target system's kernel.
>
> 2) in case of packages needing kernel headers (or sources) for building
> a) doing the check in pkg_setup() breaks binpkgs support (the check
> becomes part of a build time task, and not install time)
.. so you're recommending the check be moved to pkg_preinst() ? Or
perhaps duplicated into both pkg_setup/pkg_pretend and pkg_preinst ?
That would be doable, wouldn't it?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
iF4EAREIAAYFAk60BMQACgkQAJxUfCtlWe17qwEAhh2udNzptIJZHeEyh8DJhTj3
HLbC/ZpIJUQTbpHueOEBAITcA3DasGAQIdSWGvn7E2xwYMFTS+U0UyDWJCesv5xR
=U+gT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-11-04 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:59 [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel "Paweł Hajdan, Jr."
2011-11-04 13:13 ` Fabio Erculiani
2011-11-04 13:23 ` Patrick Lauer
2011-11-04 13:33 ` Nirbheek Chauhan
2011-11-04 14:46 ` Mike Gilbert
2011-11-04 15:11 ` Fabio Erculiani
2011-11-04 15:29 ` Ian Stakenvicius [this message]
2011-11-04 15:54 ` Fabio Erculiani
2011-11-04 21:18 ` Robin H. Johnson
2011-11-04 22:02 ` Fabio Erculiani
2011-11-04 22:12 ` Robin H. Johnson
2011-11-04 22:16 ` Fabio Erculiani
2011-11-04 21:16 ` Robin H. Johnson
2011-11-05 23:14 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB404C4.2050602@gentoo.org \
--to=axs@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox