From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RDiAX-00031N-FG for garchives@archives.gentoo.org; Tue, 11 Oct 2011 19:39:17 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E4AD721C202; Tue, 11 Oct 2011 19:38:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3CEE321C1D8 for ; Tue, 11 Oct 2011 19:38:06 +0000 (UTC) Received: from [192.168.168.169] (dyn-199-173-dsl.vsp.fi [83.146.199.173]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ssuominen) by smtp.gentoo.org (Postfix) with ESMTPSA id 5C8161B400B for ; Tue, 11 Oct 2011 19:38:05 +0000 (UTC) Message-ID: <4E949B22.50902@gentoo.org> Date: Tue, 11 Oct 2011 22:38:10 +0300 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20111005 Thunderbird/7.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild References: <20111011164918.2103A2004B@flycatcher.gentoo.org> <4E9475E1.30708@gentoo.org> <20111011170555.GV704@gentoo.org> <4E948484.1000509@gentoo.org> <20111011181358.GW704@gentoo.org> <4E948C2E.2000706@gentoo.org> <20111011184604.GX704@gentoo.org> In-Reply-To: <20111011184604.GX704@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: X-Archives-Hash: 902fc7580687f2773adbfc46b3b4f2bf On 10/11/2011 09:46 PM, Fabian Groffen wrote: > On 11-10-2011 21:34:22 +0300, Samuli Suominen wrote: >> Thanks, the end result of installed files look now OK. Care to reopen >> the stabilization bug? The changes are trivial. > > Shall we stick to the policy and wait 30 days without bugs first? OK, no hurry. >> I just hope nobody will take an example of the ebuild with code >> duplication (multiple epatch calls), overquoting, redudant use of find >> when rm is more than enough, ... > > I just like the documented way of doing things [1], so I hope many > people will just stick to that for maintainability, in favour of pseudo > efficiency. > > > [1] http://devmanual.gentoo.org/ebuild-writing/functions/src_prepare/epatch/index.html > This document should be fixed. Any comments about the patches belong to header of those patches, available for possible upstreams as well. Doesn't belong to ebuilds. So it very rarely makes sense to call epatch multiple times, and certainly doesn't improve maintainability. - Samuli