public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Samuli Suominen <ssuominen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] autotools-utils.eclass: punt unnecessary .la files even w/ USE=static-libs.
Date: Tue, 13 Sep 2011 01:34:03 +0300	[thread overview]
Message-ID: <4E6E88DB.5080204@gentoo.org> (raw)
In-Reply-To: <20110912215148.GB31178@comet>

On 09/13/2011 12:51 AM, Donnie Berkholz wrote:
> On 00:46 Tue 13 Sep     , Samuli Suominen wrote:
>>> If I understand correctly, this will break for any packages that 
>>> don't use pkg-config to link. The maintainers will manually need to 
>>> add pkg-config calls to the ebuilds of anything that could 
>>> statically link against a library using only libtool and not 
>>> pkg-config. Is that accurate?
>>
>> Yes, seems accurate.
>>
>> I can think of 'export PKG_CONFIG="$($(tc-getPKG_CONFIG) --static)' or 
>> something like 'export FOO_LIBS="$($(tc-getPKG_CONFIG) --libs --static 
>> foo)"' to accomplish getting static flags from an ebuild using 
>> toolchain-funcs.eclass if required.
>>
>> Or they do it like lvm2 and cryptsetup at upstream level and add 
>> support for statically linking the tools in the build-system.
>>
>> The .la files are not helping packages not using libtool in any case, 
>> for example, those using cmake as build-system.
>>
>> And I've yet to see a real, in portage residing, example of where this 
>> would really break anything and when I will, I'll gladly help 
>> migrating it to the example mentioned above... Overall, corner cases 
>> that can be easily worked around, yet punting the *harmful* .la files.
> 
> That's rather shocking. All it would take is trying to statically build 
> a package not using pkg-config that links against anything X11-related 
> (since all of them have .pc files).

Those packages that have pkg-config file, like libX11, are meant to be
used through pkg-config, so the bug would be in the package not using
the .pc, not in the package lacking the .la

> It's probably more that "nobody" cares about static building than that 
> there aren't packages that would break.

I'm looking forward in catching those packages trying to link statically
to a package providing valid pkg-config file, yet not using it...



  reply	other threads:[~2011-09-12 22:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12 19:57 [gentoo-dev] [PATCH] autotools-utils.eclass: punt unnecessary .la files even w/ USE=static-libs Michał Górny
2011-09-12 21:00 ` Donnie Berkholz
2011-09-12 21:46   ` Samuli Suominen
2011-09-12 21:51     ` Donnie Berkholz
2011-09-12 22:34       ` Samuli Suominen [this message]
2011-09-12 21:58   ` Michał Górny
2011-09-12 22:10     ` Donnie Berkholz
2011-09-13  6:40       ` Michał Górny
2011-09-13 14:10 ` [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 2/9] Strip ${D} from removal message to shorten it Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 3/9] For .la removal, look for static archives rather than USE=static-libs Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 4/9] Clean up & simplify la removal code a little Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 5/9] Check command-line args completely in remove_libtool_files() Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 6/9] Refactor remove_libtool_files() to simplify conditions Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 7/9] Drop 'empty' .la files as well (those lacking libs & flags) Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 8/9] Remove static libs covered by .pc files as well Michał Górny
2011-09-13 14:10   ` [gentoo-dev] [PATCH autotools-utils 9/9] Explain .la removal reasons in output Michał Górny
2011-09-13 15:13   ` [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files Dirkjan Ochtman
2011-09-13 16:23     ` Nirbheek Chauhan
2011-09-16 13:45       ` Donnie Berkholz
2011-09-13 18:33     ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6E88DB.5080204@gentoo.org \
    --to=ssuominen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox