* [gentoo-dev] RFC: devqawarn()?
@ 2011-09-01 9:03 Michał Górny
2011-09-01 10:44 ` Petteri Räty
0 siblings, 1 reply; 11+ messages in thread
From: Michał Górny @ 2011-09-01 9:03 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
Hello,
A quick idea. Right now eclasses sometimes do API changes and start
yelling at users merging ebuilds using outdates APIs. This often means
users start filling bugs about outdated ebuilds requiring maintainers
either to ignore that or start updating old ebuilds retroactively.
Maybe we should add some kind of devqawarn() function to eutils.eclass,
which would trigger special QA warnings only when ebuild is merged by
a developer? This could be triggered e.g. by some kind of voluntary
make.conf setting.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 9:03 [gentoo-dev] RFC: devqawarn()? Michał Górny
@ 2011-09-01 10:44 ` Petteri Räty
2011-09-01 10:51 ` Michał Górny
0 siblings, 1 reply; 11+ messages in thread
From: Petteri Räty @ 2011-09-01 10:44 UTC (permalink / raw
To: gentoo-dev
On 1.9.2011 12.03, Michał Górny wrote:
> Hello,
>
> A quick idea. Right now eclasses sometimes do API changes and start
> yelling at users merging ebuilds using outdates APIs. This often means
> users start filling bugs about outdated ebuilds requiring maintainers
> either to ignore that or start updating old ebuilds retroactively.
>
> Maybe we should add some kind of devqawarn() function to eutils.eclass,
> which would trigger special QA warnings only when ebuild is merged by
> a developer? This could be triggered e.g. by some kind of voluntary
> make.conf setting.
>
What's wrong with eqawarn that's already provided by eutils?
Regards,
Petteri
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 10:44 ` Petteri Räty
@ 2011-09-01 10:51 ` Michał Górny
2011-09-01 11:02 ` Petteri Räty
0 siblings, 1 reply; 11+ messages in thread
From: Michał Górny @ 2011-09-01 10:51 UTC (permalink / raw
To: gentoo-dev; +Cc: betelgeuse
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Thu, 01 Sep 2011 13:44:47 +0300
Petteri Räty <betelgeuse@gentoo.org> wrote:
> On 1.9.2011 12.03, Michał Górny wrote:
> > Hello,
> >
> > A quick idea. Right now eclasses sometimes do API changes and start
> > yelling at users merging ebuilds using outdates APIs. This often
> > means users start filling bugs about outdated ebuilds requiring
> > maintainers either to ignore that or start updating old ebuilds
> > retroactively.
> >
> > Maybe we should add some kind of devqawarn() function to
> > eutils.eclass, which would trigger special QA warnings only when
> > ebuild is merged by a developer? This could be triggered e.g. by
> > some kind of voluntary make.conf setting.
> >
>
> What's wrong with eqawarn that's already provided by eutils?
The first paragraph?
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 10:51 ` Michał Górny
@ 2011-09-01 11:02 ` Petteri Räty
2011-09-01 11:31 ` Michał Górny
2011-09-01 15:25 ` Zac Medico
0 siblings, 2 replies; 11+ messages in thread
From: Petteri Räty @ 2011-09-01 11:02 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-dev
On 1.9.2011 13.51, Michał Górny wrote:
> On Thu, 01 Sep 2011 13:44:47 +0300
> Petteri Räty <betelgeuse@gentoo.org> wrote:
>
>> On 1.9.2011 12.03, Michał Górny wrote:
>>> Hello,
>>>
>>> A quick idea. Right now eclasses sometimes do API changes and start
>>> yelling at users merging ebuilds using outdates APIs. This often
>>> means users start filling bugs about outdated ebuilds requiring
>>> maintainers either to ignore that or start updating old ebuilds
>>> retroactively.
>>>
>>> Maybe we should add some kind of devqawarn() function to
>>> eutils.eclass, which would trigger special QA warnings only when
>>> ebuild is merged by a developer? This could be triggered e.g. by
>>> some kind of voluntary make.conf setting.
>>>
>>
>> What's wrong with eqawarn that's already provided by eutils?
>
> The first paragraph?
>
Have Portage defaults so that users only see if them if they read the
merge logs and then developer profiles can set the settings to log them?
Regards,
Petteri
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 11:02 ` Petteri Räty
@ 2011-09-01 11:31 ` Michał Górny
2011-09-01 11:44 ` Petteri Räty
2011-09-01 15:25 ` Zac Medico
1 sibling, 1 reply; 11+ messages in thread
From: Michał Górny @ 2011-09-01 11:31 UTC (permalink / raw
To: gentoo-dev; +Cc: betelgeuse
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Thu, 01 Sep 2011 14:02:11 +0300
Petteri Räty <betelgeuse@gentoo.org> wrote:
> On 1.9.2011 13.51, Michał Górny wrote:
> > On Thu, 01 Sep 2011 13:44:47 +0300
> > Petteri Räty <betelgeuse@gentoo.org> wrote:
> >
> >> On 1.9.2011 12.03, Michał Górny wrote:
> >>> Hello,
> >>>
> >>> A quick idea. Right now eclasses sometimes do API changes and
> >>> start yelling at users merging ebuilds using outdates APIs. This
> >>> often means users start filling bugs about outdated ebuilds
> >>> requiring maintainers either to ignore that or start updating old
> >>> ebuilds retroactively.
> >>>
> >>> Maybe we should add some kind of devqawarn() function to
> >>> eutils.eclass, which would trigger special QA warnings only when
> >>> ebuild is merged by a developer? This could be triggered e.g. by
> >>> some kind of voluntary make.conf setting.
> >>>
> >>
> >> What's wrong with eqawarn that's already provided by eutils?
> >
> > The first paragraph?
> >
>
> Have Portage defaults so that users only see if them if they read the
> merge logs and then developer profiles can set the settings to log
> them?
1) that's changing existing behavior,
2) what with non-portage users?
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 11:31 ` Michał Górny
@ 2011-09-01 11:44 ` Petteri Räty
2011-09-01 14:12 ` Donnie Berkholz
0 siblings, 1 reply; 11+ messages in thread
From: Petteri Räty @ 2011-09-01 11:44 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-dev
On 1.9.2011 14.31, Michał Górny wrote:
> On Thu, 01 Sep 2011 14:02:11 +0300
> Petteri Räty <betelgeuse@gentoo.org> wrote:
>
>> On 1.9.2011 13.51, Michał Górny wrote:
>>> On Thu, 01 Sep 2011 13:44:47 +0300
>>> Petteri Räty <betelgeuse@gentoo.org> wrote:
>>>
>>>> On 1.9.2011 12.03, Michał Górny wrote:
>>>>> Hello,
>>>>>
>>>>> A quick idea. Right now eclasses sometimes do API changes and
>>>>> start yelling at users merging ebuilds using outdates APIs. This
>>>>> often means users start filling bugs about outdated ebuilds
>>>>> requiring maintainers either to ignore that or start updating old
>>>>> ebuilds retroactively.
>>>>>
>>>>> Maybe we should add some kind of devqawarn() function to
>>>>> eutils.eclass, which would trigger special QA warnings only when
>>>>> ebuild is merged by a developer? This could be triggered e.g. by
>>>>> some kind of voluntary make.conf setting.
>>>>>
>>>>
>>>> What's wrong with eqawarn that's already provided by eutils?
>>>
>>> The first paragraph?
>>>
>>
>> Have Portage defaults so that users only see if them if they read the
>> merge logs and then developer profiles can set the settings to log
>> them?
>
> 1) that's changing existing behavior,
> 2) what with non-portage users?
>
1) eqawarn == devqawarn. I don't see a reason to come up with a new
function just to avoid changing Portage configuration.
2) How messages from each e* function is shown is left to the package
manager to decide.
One thing to note is that we should get eqawarn into the next EAPI.
Regards,
Petteri
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 11:44 ` Petteri Räty
@ 2011-09-01 14:12 ` Donnie Berkholz
2011-09-01 15:37 ` Petteri Räty
0 siblings, 1 reply; 11+ messages in thread
From: Donnie Berkholz @ 2011-09-01 14:12 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
On 14:44 Thu 01 Sep , Petteri Räty wrote:
> One thing to note is that we should get eqawarn into the next EAPI.
Why?
--
Thanks,
Donnie
Donnie Berkholz
Council Member / Sr. Developer
Gentoo Linux
Blog: http://dberkholz.com
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 11:02 ` Petteri Räty
2011-09-01 11:31 ` Michał Górny
@ 2011-09-01 15:25 ` Zac Medico
2011-09-01 16:19 ` Michał Górny
1 sibling, 1 reply; 11+ messages in thread
From: Zac Medico @ 2011-09-01 15:25 UTC (permalink / raw
To: gentoo-dev
On 09/01/2011 04:02 AM, Petteri Räty wrote:
> Have Portage defaults so that users only see if them if they read the
> merge logs and then developer profiles can set the settings to log them?
As far as I know, this is already the case. The current default set by
portage in /usr/share/portage/config/make.globals is
PORTAGE_ELOG_CLASSES="log warn error", and in the developer profile
gentoo-x86/profiles/targets/developer/make.defaults we have
PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa".
--
Thanks,
Zac
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 14:12 ` Donnie Berkholz
@ 2011-09-01 15:37 ` Petteri Räty
0 siblings, 0 replies; 11+ messages in thread
From: Petteri Räty @ 2011-09-01 15:37 UTC (permalink / raw
To: gentoo-dev
On 1.9.2011 17.12, Donnie Berkholz wrote:
> On 14:44 Thu 01 Sep , Petteri Räty wrote:
>> One thing to note is that we should get eqawarn into the next EAPI.
>
> Why?
>
So that it wouldn't fall back on einfo where not available.
Regards,
Petteri
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 15:25 ` Zac Medico
@ 2011-09-01 16:19 ` Michał Górny
2011-09-01 17:11 ` Zac Medico
0 siblings, 1 reply; 11+ messages in thread
From: Michał Górny @ 2011-09-01 16:19 UTC (permalink / raw
To: gentoo-dev; +Cc: zmedico
[-- Attachment #1.1: Type: text/plain, Size: 723 bytes --]
On Thu, 01 Sep 2011 08:25:14 -0700
Zac Medico <zmedico@gentoo.org> wrote:
> On 09/01/2011 04:02 AM, Petteri Räty wrote:
> > Have Portage defaults so that users only see if them if they read
> > the merge logs and then developer profiles can set the settings to
> > log them?
>
> As far as I know, this is already the case. The current default set by
> portage in /usr/share/portage/config/make.globals is
> PORTAGE_ELOG_CLASSES="log warn error", and in the developer profile
> gentoo-x86/profiles/targets/developer/make.defaults we have
> PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa".
How about adjusting the eutils.eclass fallback to do so?
Patch attached.
--
Best regards,
Michał Górny
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: .diff --]
[-- Type: text/x-patch, Size: 524 bytes --]
Index: eutils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.362
diff -u -B -d -u -p -r1.362 eutils.eclass
--- eutils.eclass 9 Aug 2011 00:43:48 -0000 1.362
+++ eutils.eclass 1 Sep 2011 16:16:40 -0000
@@ -70,7 +70,9 @@ fi
# implementation if available.
if ! declare -F eqawarn >/dev/null ; then
eqawarn() {
- einfo "$@"
+ if has qa ${PORTAGE_ELOG_CLASSES}; then
+ ewarn "$@"
+ fi
}
fi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [gentoo-dev] RFC: devqawarn()?
2011-09-01 16:19 ` Michał Górny
@ 2011-09-01 17:11 ` Zac Medico
0 siblings, 0 replies; 11+ messages in thread
From: Zac Medico @ 2011-09-01 17:11 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/01/2011 09:19 AM, Michał Górny wrote:
> On Thu, 01 Sep 2011 08:25:14 -0700 Zac Medico <zmedico@gentoo.org>
> wrote:
>
>> On 09/01/2011 04:02 AM, Petteri Räty wrote:
>>> Have Portage defaults so that users only see if them if they
>>> read the merge logs and then developer profiles can set the
>>> settings to log them?
>>
>> As far as I know, this is already the case. The current default
>> set by portage in /usr/share/portage/config/make.globals is
>> PORTAGE_ELOG_CLASSES="log warn error", and in the developer
>> profile gentoo-x86/profiles/targets/developer/make.defaults we
>> have PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa".
>
> How about adjusting the eutils.eclass fallback to do so?
>
> Patch attached.
>
> Index: eutils.eclass
> ===================================================================
>
>
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
> retrieving revision 1.362 diff -u -B -d -u -p -r1.362
> eutils.eclass --- eutils.eclass 9 Aug 2011 00:43:48 -0000 1.362 +++
> eutils.eclass 1 Sep 2011 16:16:40 -0000 @@ -70,7 +70,9 @@ fi #
> implementation if available. if ! declare -F eqawarn >/dev/null ;
> then eqawarn() { - einfo "$@" + if has qa
> ${PORTAGE_ELOG_CLASSES}; then + ewarn "$@" + fi } fi
Looks good to me.
- --
Thanks,
Zac
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5fvMQACgkQ/ejvha5XGaMyQwCgqS63azOhQF/pWBNq1kN4vNr0
nMQAnRdnwUG8GFaSv9o5RawemeaXFWqb
=AL1B
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-09-01 17:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-01 9:03 [gentoo-dev] RFC: devqawarn()? Michał Górny
2011-09-01 10:44 ` Petteri Räty
2011-09-01 10:51 ` Michał Górny
2011-09-01 11:02 ` Petteri Räty
2011-09-01 11:31 ` Michał Górny
2011-09-01 11:44 ` Petteri Räty
2011-09-01 14:12 ` Donnie Berkholz
2011-09-01 15:37 ` Petteri Räty
2011-09-01 15:25 ` Zac Medico
2011-09-01 16:19 ` Michał Górny
2011-09-01 17:11 ` Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox