[gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages

[gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages

[justin]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

Hi all,

the following change has some bad effects on packages in the tree. I
found it with a package having this inherit line

inherit cmake-utils wxwidgets

all cmake-utils_* function which have redundant phase definitions in
base will not be executed.

This change was not trivial. So either we need to revert it or really
check the tree that nothing is broken.

thanks justin


dirtyepic    11/06/30 04:14:38

  Modified:             wxwidgets.eclass
  Log:
  Inherit base (bug #372831 by Gert Wollny).

Revision  Changes    Path
1.30                 eclass/wxwidgets.eclass

file :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/wxwidgets.eclass?rev=1.30&view=markup
plain:
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/wxwidgets.eclass?rev=1.30&content-type=text/plain
diff :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/wxwidgets.eclass?r1=1.29&r2=1.30

Index: wxwidgets.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/wxwidgets.eclass,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- wxwidgets.eclass	16 Feb 2010 01:06:24 -0000	1.29
+++ wxwidgets.eclass	30 Jun 2011 04:14:38 -0000	1.30
@@ -1,6 +1,6 @@
 # Copyright 1999-2007 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/wxwidgets.eclass,v 1.29
2010/02/16 01:06:24 dirtyepic Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/wxwidgets.eclass,v 1.30
2011/06/30 04:14:38 dirtyepic Exp $

 # @ECLASS:			wxwidgets.eclass
 # @MAINTAINER:
@@ -45,7 +45,7 @@
 #  wx-config file to use.  Most configure scripts use this path if it's
set in
 #  the environment or accept --with-wx-config="${WX_CONFIG}".

-inherit eutils multilib
+inherit base eutils multilib

 case "${EAPI:-0}" in
 	0|1)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Sun, 17 Jul 2011 11:05:39 +0200
justin <jlec@gentoo.org> wrote:

> Hi all,
> 
> the following change has some bad effects on packages in the tree. I
> found it with a package having this inherit line
> 
> inherit cmake-utils wxwidgets
> 
> all cmake-utils_* function which have redundant phase definitions in
> base will not be executed.
> 
> This change was not trivial. So either we need to revert it or really
> check the tree that nothing is broken.

Revert. The wxwidgets eclass is not really supposed to export phase
functions, I've seen packages in Sunrise using it along with
cmake-utils too. If someone wants user patches in their package, he/she
should inherit base directly and get phase funcs clean.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages

[justin]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On 17/07/11 11:16, Michał Górny wrote:
> On Sun, 17 Jul 2011 11:05:39 +0200
> justin <jlec@gentoo.org> wrote:
> 
>> Hi all,
>>
>> the following change has some bad effects on packages in the tree. I
>> found it with a package having this inherit line
>>
>> inherit cmake-utils wxwidgets
>>
>> all cmake-utils_* function which have redundant phase definitions in
>> base will not be executed.
>>
>> This change was not trivial. So either we need to revert it or really
>> check the tree that nothing is broken.
> 
> Revert. The wxwidgets eclass is not really supposed to export phase
> functions, I've seen packages in Sunrise using it along with
> cmake-utils too. If someone wants user patches in their package, he/she
> should inherit base directly and get phase funcs clean.
> 

So I checked it. There are a couple of packages which use it in
combination with cmake-utils, python and autotools-utils. And as
maintainer keeps the lines sorted, all those ebuilds are broken potentially.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[gentoo-dev] Re: recent change in wxwidgets.eclass potentially breaks packages

[Ryan Hill]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

On Sun, 17 Jul 2011 11:19:31 +0200
justin <jlec@gentoo.org> wrote:

> On 17/07/11 11:16, Michał Górny wrote:
> > On Sun, 17 Jul 2011 11:05:39 +0200
> > justin <jlec@gentoo.org> wrote:
> > 
> >> Hi all,
> >>
> >> the following change has some bad effects on packages in the tree. I
> >> found it with a package having this inherit line
> >>
> >> inherit cmake-utils wxwidgets
> >>
> >> all cmake-utils_* function which have redundant phase definitions in
> >> base will not be executed.
> >>
> >> This change was not trivial. So either we need to revert it or really
> >> check the tree that nothing is broken.
> > 
> > Revert. The wxwidgets eclass is not really supposed to export phase
> > functions, I've seen packages in Sunrise using it along with
> > cmake-utils too. If someone wants user patches in their package, he/she
> > should inherit base directly and get phase funcs clean.
> > 
> 
> So I checked it. There are a couple of packages which use it in
> combination with cmake-utils, python and autotools-utils. And as
> maintainer keeps the lines sorted, all those ebuilds are broken potentially.

And people wonder why I hate eclasses...


-- 
fonts, gcc-porting,                  it makes no sense how it makes no sense
toolchain, wxwidgets                           but i'll take it free anytime
@ gentoo.org                EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Re: recent change in wxwidgets.eclass potentially breaks packages

[Francesco Riosa]

2011/7/17 Ryan Hill <dirtyepic@gentoo.org>:
> On Sun, 17 Jul 2011 11:19:31 +0200
> justin <jlec@gentoo.org> wrote:
>
>> On 17/07/11 11:16, Michał Górny wrote:
>> > On Sun, 17 Jul 2011 11:05:39 +0200
>> > justin <jlec@gentoo.org> wrote:
>> >
>> >> Hi all,
>> >>
>> >> the following change has some bad effects on packages in the tree. I
>> >> found it with a package having this inherit line
>> >>
>> >> inherit cmake-utils wxwidgets
>> >>
>> >> all cmake-utils_* function which have redundant phase definitions in
>> >> base will not be executed.
>> >>
>> >> This change was not trivial. So either we need to revert it or really
>> >> check the tree that nothing is broken.
>> >
>> > Revert. The wxwidgets eclass is not really supposed to export phase
>> > functions, I've seen packages in Sunrise using it along with
>> > cmake-utils too. If someone wants user patches in their package, he/she
>> > should inherit base directly and get phase funcs clean.
>> >
>>
>> So I checked it. There are a couple of packages which use it in
>> combination with cmake-utils, python and autotools-utils. And as
>> maintainer keeps the lines sorted, all those ebuilds are broken potentially.
>
> And people wonder why I hate eclasses...
>

I would hate more seeing $PORTDIR go from 180MB to 1800MB, and a few
more thing you already know ;)