[gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[Samuli Suominen]

I've never used eclass/tests/ or are familiar with where it's used, so
can I get an ACK or two for this?

--- eclass/tests/tests-common.sh.orig	2011-07-11 21:04:16.000000000 +0300
+++ eclass/tests/tests-common.sh	2011-07-11 21:04:40.000000000 +0300
@@ -27,5 +27,4 @@
 	debug-print "now in section ${*}"
 }

-hasq() { [[ " ${*:2} " == *" $1 "* ]]; }
-has() { hasq "$@"; }
+has() { [[ " ${*:2} " == *" $1 "* ]]; }

Re: [gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

On Mon, 11 Jul 2011 21:06:47 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:
> I've never used eclass/tests/ or are familiar with where it's used, so
> can I get an ACK or two for this?

See https://bugs.gentoo.org/show_bug.cgi?id=374791

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[Samuli Suominen]

On 07/11/2011 09:11 PM, Ciaran McCreesh wrote:
> On Mon, 11 Jul 2011 21:06:47 +0300
> Samuli Suominen <ssuominen@gentoo.org> wrote:
>> I've never used eclass/tests/ or are familiar with where it's used, so
>> can I get an ACK or two for this?
> 
> See https://bugs.gentoo.org/show_bug.cgi?id=374791
> 

Thanks for pointing it out.

http://bugs.gentoo.org/show_bug.cgi?id=374791#c5

Should be good to go?

Re: [gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 417 bytes --]

On Monday, July 11, 2011 14:06:47 Samuli Suominen wrote:
> I've never used eclass/tests/ or are familiar with where it's used

it doesnt get used directly anywhere.  it's a handy dir for people to put 
testsuites of their eclasses and then run manually when they're changing the 
eclasses to make sure they didnt break anything.

> so can I get an ACK or two for this?

since i wrote it, fine by me.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] RFC: Small patch to get rid of last hasq() in eclass/tests/

[Samuli Suominen]

On 07/11/2011 09:36 PM, Mike Frysinger wrote:
> On Monday, July 11, 2011 14:06:47 Samuli Suominen wrote:
>> I've never used eclass/tests/ or are familiar with where it's used
> 
> it doesnt get used directly anywhere.  it's a handy dir for people to put 
> testsuites of their eclasses and then run manually when they're changing the 
> eclasses to make sure they didnt break anything.
> 
>> so can I get an ACK or two for this?
> 
> since i wrote it, fine by me.
> -mike

A bit different version went in,

http://bugs.gentoo.org/show_bug.cgi?id=374791#c9
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/tests/tests-common.sh?r1=1.3&r2=1.4