From: "Tomáš Chvátal" <scarabeus@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: git-2.eclass final review
Date: Mon, 18 Apr 2011 11:45:00 +0200 [thread overview]
Message-ID: <4DAC081C.2070400@gentoo.org> (raw)
In-Reply-To: <m3r590bug6.fsf@jhcloos.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dne 17.4.2011 20:31, James Cloos napsal(a):
> That looks good (by inspection).
>
> My only concern is the branch deletion in the non-bare update.
>
> First of all, * should be escaped. It seems to work OK with gnu grep,
> but it would be better to be explicit. (grep(1) says that only ?+{|()
> loose their meta-meaning in basic regexps.)
>
> Second, why delete the other branches at all? I'd rather have a
> complete clone. Just the checkout ought to be enough.
>
> Otherwise, cool.
>
> -JimC
They are local clones -> they can be deleted on remote already, so we
wipe them all expect master every time unless needed.
No need to escape it if it is in "". it is parsed as the char itself
like this.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk2sCBwACgkQHB6c3gNBRYddlgCfcK1sl4NKmOBWDWP9AJtEzgyw
VGEAmgLY4roHyg8+2szY/lB0B30jaZZv
=X/fM
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-18 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 21:07 [gentoo-dev] git-2.eclass final review Tomáš Chvátal
2011-03-22 21:26 ` Mike Frysinger
2011-03-22 22:38 ` Tomáš Chvátal
2011-03-22 23:08 ` Mike Frysinger
2011-03-22 23:41 ` [gentoo-dev] " Ryan Hill
2011-03-22 23:45 ` Ryan Hill
2011-03-22 23:55 ` Mike Frysinger
2011-03-23 12:28 ` James Cloos
2011-03-23 13:01 ` Tomáš Chvátal
2011-03-23 14:44 ` James Cloos
2011-03-24 12:54 ` Donnie Berkholz
2011-03-23 16:29 ` Donnie Berkholz
2011-03-24 10:52 ` James Cloos
2011-03-23 0:42 ` [gentoo-dev] " Tomáš Chvátal
2011-03-31 4:55 ` Jeroen Roovers
2011-03-31 6:32 ` Tomáš Chvátal
2011-03-31 7:29 ` Fabian Groffen
2011-03-31 16:00 ` Matt Turner
2011-03-31 21:23 ` Aaron W. Swenson
2011-04-05 15:18 ` Marc Schiffbauer
2011-04-17 8:44 ` [gentoo-dev] " Tomá? Chvátal
2011-04-17 18:31 ` James Cloos
2011-04-18 9:45 ` Tomáš Chvátal [this message]
2011-04-18 17:55 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAC081C.2070400@gentoo.org \
--to=scarabeus@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox