From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Q6gkq-0004WI-Bo for garchives@archives.gentoo.org; Mon, 04 Apr 2011 10:11:28 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 54C491C061; Mon, 4 Apr 2011 10:11:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 4C80E1C03E for ; Mon, 4 Apr 2011 10:10:46 +0000 (UTC) Received: from [192.168.1.3] (ip-94-112-147-25.net.upcbroadband.cz [94.112.147.25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: scarabeus) by smtp.gentoo.org (Postfix) with ESMTPSA id E4B7D1B401C; Mon, 4 Apr 2011 10:10:44 +0000 (UTC) Message-ID: <4D9997BC.9090004@gentoo.org> Date: Mon, 04 Apr 2011 12:04:44 +0200 From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Lightning/1.0b3pre Thunderbird/3.1.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org, qa@gentoo.org Subject: Re: [gentoo-dev] Re: python-namespaces.eclass References: <201104031938.18311.Arfrever@gentoo.org> <4D98CA42.6010204@gentoo.org> <201104040113.37972.Arfrever@gentoo.org> In-Reply-To: <201104040113.37972.Arfrever@gentoo.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: d172188f6ea2e8b13b200aea49ddb42f -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 4.4.2011 01:13, Arfrever Frehtes Taifersar Arahesis napsal(a): > 2011-04-03 21:28:02 Tom=C3=A1=C5=A1 Chv=C3=A1tal napisa=C5=82(a): >> Dne 3.4.2011 19:38, Arfrever Frehtes Taifersar Arahesis napsal(a): >>> I would like to add python-namespaces.eclass. This eclass will be use= d by a small number of >>> special packages, which will provide Python namespaces. These package= s will be used as >>> dependencies of other packages already present in the tree. >>> >>> Ebuilds using this eclass must set PYTHON_NAMESPACES variable before = inheriting this eclass. >>> Example (from net-zope/namespaces-zope): >>> PYTHON_NAMESPACES=3D"Products Shared Shared.DC five +zope zope.app" >>> >>> This eclass provides 3 public functions: >>> python-namespaces_src_install() >>> python-namespaces_pkg_postinst() >>> python-namespaces_pkg_postrm() >>> >> Why you do so much overquoting in the conditions? >=20 > I like consistency with python.eclass and improved syntax highlighting = :) . Improved syntax highlighting? Apart from making it a bit larger that indeed is not a point if bash has to process and strip all the quotes your code is to be slower than the one without them. >=20 >> Why do you die on those arguments, just ignore them... >=20 > The policy for Python-related eclasses is to not ignore misusage of fun= ctions. It is policy defined by you that makes the code larger for no gain. You do the same when you check if the ebuild scope is the same for the function. These checks are not required for any aparent reason. If developer wants to execute src_unpack in src_prepare and shoot himself into his leg eclasses are not the one that should prevent him from doing so. Basically you just add useless logic into the functions, so please do not do that. (this apply for all your patches) >=20 >> You could use some eclass-debug calls (see other eclasses) :) >=20 > IMHO they are helpless in debugging. 'set -x' enabled by -d option of e= merge is more helpful. >=20 Ok if you don't feel it helps the development then indeed it is not required to set them :) >> Why do you call those set_metadata right after its creation and delete >> it right away, does it save so much time it is better than doing it in >> global scope? >=20 > It is used to have appropriate scope for local variables, so that they = don't have to be unset > manually immediately after the code, in which they should exist. >=20 OOk works for me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2Zl7wACgkQHB6c3gNBRYeH9wCfcac24FDG2t8Z1JFZbZ8AQDSv Oq0An3AIfm+JehVVhZksgxmwNfhWi0Sd =3D0qyh -----END PGP SIGNATURE-----