From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Q4g72-0000kx-IG for garchives@archives.gentoo.org; Tue, 29 Mar 2011 21:06:04 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B50C81C043; Tue, 29 Mar 2011 21:05:54 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A75731C039 for ; Tue, 29 Mar 2011 21:05:22 +0000 (UTC) Received: from [192.168.1.3] (pool-68-238-114-72.atl.dsl-w.verizon.net [68.238.114.72]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: titanofold) by smtp.gentoo.org (Postfix) with ESMTPSA id 051FA1B406C for ; Tue, 29 Mar 2011 21:05:17 +0000 (UTC) Message-ID: <4D92497D.30100@gentoo.org> Date: Tue, 29 Mar 2011 17:05:01 -0400 From: "Aaron W. Swenson" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110310 Lightning/1.0b3pre Thunderbird/3.1.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: postgresql.eselect References: <4D914FC5.7040109@gentoo.org> <19857.41217.854435.807699@a1i15.kph.uni-mainz.de> In-Reply-To: <19857.41217.854435.807699@a1i15.kph.uni-mainz.de> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: X-Archives-Hash: 701681b4b1912670e13acd1431bf6420 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 03/29/2011 05:06 AM, Ulrich Mueller wrote: >>>>>> On Mon, 28 Mar 2011, Aaron W Swenson wrote: > >> This module is to replace the existing one that is shipped with >> > Some remarks: > > - Global scope code is a no-no in eselect modules, especially if it > calls external programs or accesses external files. Your module > will be sourced for commands like "eselect modules list" and there > shouldn't be any global scope code being run on such occasions. > Fixed. > - Don't use eval. It's almost always an indication that you're doing > something wrong. > Yeah, I should have used 'find' as fewer "tricks" are needed. Wonder why I didn't do that in the first place.... > - For tests, please use [[ ]] rather than [ ] throughout. > Done. > - "output" and "path-manipulation" libraries are always loaded, so you > need not (and in fact, you shouldn't) inherit them. > The dev guide could be clearer on that. Removed them from the inherit line. > - Don't hardcode terminal specific escape sequences (like "\033[1m"). > Use the highlighting functions of the output library instead (which > in turn use tput). > Except $(highlight ...) doesn't work in plain echo. So, I just stripped it out. > - Suppressing stdout of commands like "do_action env update" is fine, > but why suppress stderr? > Because 'ls' would complain that files didn't exist, such as lib*.dylib when on a Linux system. It doesn't matter. But, using 'find' avoids this mess. > - Please avoid lines wider than 79 positions. > Did where I could. > See also eselect's README and the developer guide: > Never knew that existed. Thanks for pointing that out. > > That's where I got all of my information. > Ulrich > Thank you for the feedback. It was quite helpful. Now, I'm a bit sketchy on the handling of choosing which bitness for the executables. (psql and friends.) Sincerely, Mr. Aaron W. Swenson -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREIAAYFAk2SSX0ACgkQCOhwUhu5AEk4xQD9E6jabiGSNYycJSU871p82H1O 0iIU1kBV2HMhfJId/NgA/0Zoq2O3Pcy9O2OcthsQb6e8ZipJZ+dpffMCaC0zOqrs =L/aO -----END PGP SIGNATURE-----