From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Q2AG3-0007L0-7A for garchives@archives.gentoo.org; Tue, 22 Mar 2011 22:40:59 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D7D991C0E1; Tue, 22 Mar 2011 22:40:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 76B821C042 for ; Tue, 22 Mar 2011 22:40:16 +0000 (UTC) Received: from [192.168.1.3] (ip-94-112-147-25.net.upcbroadband.cz [94.112.147.25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: scarabeus) by smtp.gentoo.org (Postfix) with ESMTPSA id B99C11B4076 for ; Tue, 22 Mar 2011 22:40:14 +0000 (UTC) Message-ID: <4D8924CD.8000404@gentoo.org> Date: Tue, 22 Mar 2011 23:38:05 +0100 From: =?windows-1252?Q?Tom=E1=9A_Chv=E1tal?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Lightning/1.0b3pre Thunderbird/3.1.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] git-2.eclass final review References: <4D890F8D.4090706@gentoo.org> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: X-Archives-Hash: 12b03522cf3869102aec2da4597cd23a -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 22.3.2011 22:26, Mike Frysinger napsal(a): >> # @BLURB: This eclass provides functions for fetch and unpack git repositories > > fetching/unpacking Yarp fixed. > >> eval X="\$${PN//[-+]/_}_LIVE_REPO" >> if [[ ${X} = "" ]]; then >> : ${EGIT_REPO_URI:=} >> else >> EGIT_REPO_URI="${X}" >> fi > > X needs to be marked local, and could be condensed: > EGIT_REPO_URI=${X:-${EGIT_REPO_URI}} > Hopefully implemented. > the PN_LIVE_REPO override documentation is missing It is on purpose. It is semisecret hack that allows you to localy bend live ebuilds without any need for rewriting it or adding some variables (eg. reason why we have just one live mesa ebuild and no branches based ones). If you think this thing should be official we can document it, but i really really think that people by default should not be aware of this. > > same feedback for all the vars after this too > >> git-2_fetch $@ > > missing quotes Fixed Handy link to gitdiff over gitweb: http://tinyurl.com/6focxa9 Thanks Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2JJM0ACgkQHB6c3gNBRYd7fQCffqyoRouirScE2B8npuhEjLEF Hx4AnRuyyIs5OG3WnRfKgM9itydIpJdE =Nlbz -----END PGP SIGNATURE-----