Re: [gentoo-dev] git-2.eclass final review

["Tomáš Chvátal" <scarabeus@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
>> # @BLURB: This eclass provides functions for fetch and unpack git repositories
> 
> fetching/unpacking

Yarp fixed.
> 
>> 	eval X="\$${PN//[-+]/_}_LIVE_REPO"
>> 	if [[ ${X} = "" ]]; then
>> 		: ${EGIT_REPO_URI:=}
>> 	else
>> 		EGIT_REPO_URI="${X}"
>> 	fi
> 
> X needs to be marked local, and could be condensed:
> EGIT_REPO_URI=${X:-${EGIT_REPO_URI}}
> 
Hopefully implemented.

> the PN_LIVE_REPO override documentation is missing
It is on purpose.
It is semisecret hack that allows you to localy bend live ebuilds
without any need for rewriting it or adding some variables (eg. reason
why we have just one live mesa ebuild and no branches based ones).

If you think this thing should be official we can document it, but i
really really think that people by default should not be aware of this.
> 
> same feedback for all the vars after this too
> 
>> 	git-2_fetch $@
> 
> missing quotes
Fixed

Handy link to gitdiff over gitweb: http://tinyurl.com/6focxa9

Thanks

Tom



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2JJM0ACgkQHB6c3gNBRYd7fQCffqyoRouirScE2B8npuhEjLEF
Hx4AnRuyyIs5OG3WnRfKgM9itydIpJdE
=Nlbz
-----END PGP SIGNATURE-----