From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Pzkkp-0001DX-5N for garchives@archives.gentoo.org; Wed, 16 Mar 2011 07:02:50 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 224371C08E; Wed, 16 Mar 2011 07:02:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 02A801C026 for ; Wed, 16 Mar 2011 07:02:05 +0000 (UTC) Received: from paul.ibi.kfa-juelich.de (ibi109.ibi.kfa-juelich.de [134.94.85.208]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id B05352AC03F; Wed, 16 Mar 2011 07:02:04 +0000 (UTC) Message-ID: <4D806069.5050200@gentoo.org> Date: Wed, 16 Mar 2011 08:02:01 +0100 From: justin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Lightning/1.0b3pre Thunderbird/3.1.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: emboss.eclass as replacement for embassy.eclass References: <4D7F1633.1080104@gentoo.org> <4D7FD134.4060606@gentoo.org> <201103151806.36778.vapier@gentoo.org> In-Reply-To: <201103151806.36778.vapier@gentoo.org> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8E72A9A6BBD4801FD0B29383" X-Archives-Salt: X-Archives-Hash: e4f6d0c6be9f80dd94d294ea30482b0d This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8E72A9A6BBD4801FD0B29383 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 15/03/11 23:06, Mike Frysinger wrote: >> # Copyright 1999-2004 Gentoo Foundation >=20 > s/2004/2011/ >=20 > have you looked at the man page output for this to make sure the white = spacing=20 > you're putting into the comments properly carries over ? I will do this before the final commit. Currently it is alright. >=20 >> # @ECLASS-VARIABLE: EBO_DESCRIPTION >> # @DESCRIPTION: >> # Should be set. Completes the describtion of the embassy module as fo= llows: >=20 > i dont understand what this is trying to say (ignoring the spelling mis= take in=20 > description) These are all modules for EMBOSS. I want to shorten the Description of each ebuild to the important part. But I will makes this clearer for the manpage. What I don't want, is what you can read in all the gstreamer plugins "plugins for foo" >> HOMEPAGE=3D"http://emboss.sourceforge.net" >=20 > could do with a trailing "/" I asked myself quite often, if this needed or not. What is the purpose of the trailing "/"? // snip // >> # $(use_with png pngdriver "${EPREFIX}/usr") >> # $(use_with pdf hpdf "${EPREFIX}/usr") >> # $(use_with mysql mysql "${EPREFIX}/usr/bin/mysql_config") >> # $(use_with postgres postgresql "${EPREFIX}/usr/bin/pg_config") >=20 > do you really need full paths here ? are the configure scripts that sc= rewed=20 > up ? ideally libs would be found via .pc files. It f..ing defaults to / roots if not specified >=20 >> # $(use_enable amd64 64) >=20 > oh god it burns so bad when i poo >=20 >> emboss_src_install() { >> default >> mv "${ED}"/usr/share/EMBOSS/doc/* "${ED}"/usr/share/doc/${PF}/ >> rm -rf "${ED}"/usr/share/EMBOSS/doc >=20 > does the configure script respect --docdir=3D ? then you wouldnt need = this=20 > clean up logic ... It soesn't and actually the java part (not installed yet) expects docs here. I am not sure where this could be left like this or breaks somehtin= g. > -mike Thanks mike for all your suggestions and remarks. I will fix the eclass accordingly. justin --------------enig8E72A9A6BBD4801FD0B29383 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2AYGkACgkQgAnW8HDreRZlmQCgtRRH2OV51yuLu905lAcrZA4a HoIAoJYbzLTP1+0OGS+lzF89UQQB4rj/ =v+x8 -----END PGP SIGNATURE----- --------------enig8E72A9A6BBD4801FD0B29383--