From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1PygdX-0005FB-QB for garchives@archives.gentoo.org; Sun, 13 Mar 2011 08:26:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E33C31C00B; Sun, 13 Mar 2011 08:26:42 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id DC017E038D for ; Sun, 13 Mar 2011 08:26:05 +0000 (UTC) Received: from [192.168.1.3] (ip-94-112-147-25.net.upcbroadband.cz [94.112.147.25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: scarabeus) by smtp.gentoo.org (Postfix) with ESMTPSA id 0E71B1B4003 for ; Sun, 13 Mar 2011 08:26:04 +0000 (UTC) Message-ID: <4D7C7F5F.70904@gentoo.org> Date: Sun, 13 Mar 2011 09:25:03 +0100 From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Lightning/1.0b3pre Thunderbird/3.1.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] virtualx eclass possible issue References: <4D7B4CE8.6030808@gentoo.org> In-Reply-To: <4D7B4CE8.6030808@gentoo.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 66401591c3b6b876d4c76970833de600 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 12.3.2011 11:37, "Pawe=C5=82 Hajdan, Jr." napsal(a): > One of my ebuilds is using virtualx eclass, and I noticed the following > code inside the eclass: >=20 > retval=3D$? >=20 > # Now kill Xvfb > kill $(cat /tmp/.X${XDISPLAY}-lock) > else > debug-print "${FUNCNAME}: attaching to running X display" > # Normal make if we can connect to an X display > debug-print "${FUNCNAME}: ${VIRTUALX_COMMAND} \"$@\"" > ${VIRTUALX_COMMAND} "$@" > retval=3D$? > fi >=20 > # die if our command failed > [[ $? -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed." >=20 > Shouldn't that last line look more like this (notice $retval instead of= $?): >=20 > [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} fai= led." >=20 > What do you think? >=20 Ack to both what you said and what Michal said. Fixed in cvs :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk18f18ACgkQHB6c3gNBRYfoMACfYiOyC7nJlp/AI0gUE37KBVEL dboAnRkahB1np882D/b7R80vGU9uzXky =3DDFzF -----END PGP SIGNATURE-----