From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Og2k6-0002Kw-0e for garchives@archives.gentoo.org; Mon, 02 Aug 2010 21:40:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 07AC1E09C8; Mon, 2 Aug 2010 21:40:14 +0000 (UTC) Received: from earth.farbfinsternis.net (earth.farbfinsternis.net [87.118.98.117]) by pigeon.gentoo.org (Postfix) with ESMTP id D8B68E09D1 for ; Mon, 2 Aug 2010 21:40:12 +0000 (UTC) Received: from [192.168.178.26] (p4FD53B37.dip0.t-ipconnect.de [79.213.59.55]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by earth.farbfinsternis.net (Postfix) with ESMTPSA id A1B7D878004 for ; Mon, 2 Aug 2010 23:49:25 +0200 (CEST) Message-ID: <4C573B37.8020803@gentoo.org> Date: Mon, 02 Aug 2010 23:40:07 +0200 From: Matti Bickel User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: Reviving GLEP33 References: <4C569638.9000407@gentoo.org> <20100802111125.GA7233@hrair> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig64EDB08BDE5B125B195E8DAF" X-Archives-Salt: e3fb94f8-a0eb-4ad8-8718-7f7223cb083b X-Archives-Hash: 0b51dd5351937057832db53432e1a2c9 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig64EDB08BDE5B125B195E8DAF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/02/2010 08:16 PM, David Leverton wrote: > On 2 August 2010 12:11, Brian Harring wrote: >> On Mon, Aug 02, 2010 at 11:56:08AM +0200, Matti Bickel wrote: >>> Hi folks, >>>=20 >>> I've been told that my use of eblits in dev-lang/php is something >>> I should get rid of as soon as possible. Suggested alternative by >>> ferring: use elibs. >=20 > There's a couple of hundred lines of repeated metadata between=20 > php-5.3.2 and php-5.3.3 - not identical, but similar enough that > there would be gains from factoring it out, and elibs won't help with > that. Sure. I was thinking of providing php.eclass with the common metadata for php-5*, including patchset code, core DEPEND and the like. With the php team rather stretched nowadays, it will take a few days before that'll happen. I'm still trying to cope with the complexity of the whole php eco-system. > Am I understanding correctly in that you didn't use an eclass to > avoid cluttering up the main eclass directory with something specific > to this one package? Yes. Actually, that was hoffie's goal, when he decided to use eblits. I continued this and actually made php5_2-sapi.eclass obsolete by using eblits in php-5.2.14. Interesting sidenote: I only needed one more eblit for this - the amount of code shared went through the ceiling. > If so, it sounds like what you really want is per-package eclasses > (maybe with elibs as well to hold the non-metadata code), which > aren't covered by GLEP33 but ought to be easy enough to add. It's actually covered by GLEP33: http://www.gentoo.org/proj/en/glep/glep-0033.html#tree-restructuring And yes, it's one of it's most obvious advantages. I hate the clutter of php-* eclasses with passion (I'm aware most of them serve a good purpose)= =2E >> My suggestion? Split this into two, elibs, and eclass >> refactoring. >=20 > Per-package eclasses would be beneficial IMHO regardless of the > other eclass stuff from 33, might be worth thinking about those as > another item (consistent with the existing design plans of course) if > the rest isn't going to happen soon. If we can get that going asap without waiting, I'm all for it. --------------enig64EDB08BDE5B125B195E8DAF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkxXOzcACgkQfNMcoUhJ7GyOMQCff5mOAqou1AR7zqxyOWeZll0I 4eIAn1va7ksxDI+lyoNHOH6SvBxfAEa8 =U7wG -----END PGP SIGNATURE----- --------------enig64EDB08BDE5B125B195E8DAF--