From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OW1iC-0002cR-L2 for garchives@archives.gentoo.org; Tue, 06 Jul 2010 06:32:56 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 089DAE09F4; Tue, 6 Jul 2010 06:32:52 +0000 (UTC) Received: from petteriraty.eu (petteriraty.eu [188.40.80.83]) by pigeon.gentoo.org (Postfix) with ESMTP id 77CB5E09C3 for ; Tue, 6 Jul 2010 06:32:31 +0000 (UTC) Received: from [82.130.46.226] (qob2.kyla.fi [82.130.46.226]) by petteriraty.eu (Postfix) with ESMTPSA id 11D6029E3D for ; Tue, 6 Jul 2010 06:32:25 +0000 (UTC) Message-ID: <4C32CE47.3030907@gentoo.org> Date: Tue, 06 Jul 2010 09:33:43 +0300 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8.1.23) Gecko/20090916 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass References: <201007051724.02971.Arfrever@gentoo.org> <4C3261D0.7090504@gentoo.org> <20100706011827.1adea35a@epia.jer-c2.orkz.net> In-Reply-To: <20100706011827.1adea35a@epia.jer-c2.orkz.net> X-Enigmail-Version: 1.1 OpenPGP: id=B8E4ECF0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig882AB375FF40DBF6D72C7581" X-Archives-Salt: 801fb455-b083-411d-ae64-36b7dbee7ff8 X-Archives-Hash: 70100e26b2c5076e613b0da981202b12 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig882AB375FF40DBF6D72C7581 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/06/2010 02:18 AM, Jeroen Roovers wrote: > On Mon, 05 Jul 2010 22:50:56 +0000 > "Jorge Manuel B. S. Vicetto" wrote: >=20 >> I'm not going to delve into the details that have been addressed all >> other this thread. Instead I'll just address one small issue. >> The use of *minor* in the title of this thread and the sheer size of >> the patch attached are not compatible. Please don't label changes >> such as these as *minor* in future instances. >=20 > Another major flaw on its own is the sheer size of the patch (it hadn't= > been explicitly mentioned to my knowledge). Aren't we supposed to > commit early and often in open source projects instead of dumping all > your changes on reviewers at once (first fork and later merge)? And if > you're still going to do it, a the huge patch should only be necessary > to establish a single sweeping change, not many small changes. >=20 Indeed the patch should be splitted if you expect people to reasonably review it. Petteri --------------enig882AB375FF40DBF6D72C7581 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJMMs5NAAoJEPeUsk245OzwxmQQAJ3dpH1JqP+B/yePGNsZwM+g AZ6X7aRCq+OYo8lQhtZBwkKMjCCtC2noANrloJzEvD32+57YufPPS7qW8sBPBBDX MCczaiBb5BHv7yNJnkuy4NoIKGglU18Vb7UWjH2b8SVSRXxlkaKsIQg6T5qYD/EP JmwqJ2S2VPzVY567ePmAVscI7+4/oTt5L3XwjlL19gfzP9+FKrPbickoZf7QyyEY v1mkcsw5mS6jnwZh2qh+YkS3yDmhUaj6PQzmgmrN/ECLGzycnWKtS9+lHAuyzMqx yffE7Ta0Zqxo8iR5yFyCj7s7AJeEHyxyroh0W9Iaa1HEllop+F0J/VfJtUqeHqn+ ypS1YWbRVcvJU0iqE80/LOeYpN0A1ZFf0v9NzwHvjk8fTOYcOn3xfPKJLlXWLoH2 NrFDCIB4OXCGW7SL0xa+nbKB3m+nhENyzT1IaywBnUWASJzRzqeVRwAugc0HFOTO IQgkOKmvSbJEPsDd8ZHqZqLKOEjAcRhmgH15AFmwpMSEQu0R1LyMqgjeCCxm+r7T /vpZIFwU1oIeQ1QztZsvgU08EPVdsHSsz+q9VjeXE7MfaZegqDuwLmStu9RvEJ+E ipuvHY3tlL3YPkZv4SFAdb8wUVanhh+zrf4v+4fQirlYvjpZ/b1PkZ9OhxLlbjC/ ry2wk2tQm2ssawFfQQw5 =ATrT -----END PGP SIGNATURE----- --------------enig882AB375FF40DBF6D72C7581--