From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OVtWs-00087u-Hk for garchives@archives.gentoo.org; Mon, 05 Jul 2010 21:48:42 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0B35BE0C0A; Mon, 5 Jul 2010 21:48:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 22DE4E0BF4 for ; Mon, 5 Jul 2010 21:48:33 +0000 (UTC) Received: from [83.146.207.236] (dyn-207-236-dsl.vsp.fi [83.146.207.236]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id 5B59E1B404E for ; Mon, 5 Jul 2010 21:48:32 +0000 (UTC) Message-ID: <4C325386.8060902@gentoo.org> Date: Tue, 06 Jul 2010 00:49:58 +0300 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.4) Gecko/20100626 Thunderbird/3.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass References: <201007051724.02971.Arfrever@gentoo.org> <201007052223.52113.Arfrever@gentoo.org> <4C324E61.50704@gentoo.org> <201007052338.47742.Arfrever@gentoo.org> In-Reply-To: <201007052338.47742.Arfrever@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: fe1a5a93-a1e7-4051-93e8-698a496023ad X-Archives-Hash: b050566ffb29d6994d85c7d2c3a16371 On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote: > 2010-07-05 23:28:01 Samuli Suominen napisa=C5=82(a): >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: >>> 2010-07-05 21:18:57 Mark Loeser napisa=C5=82(a): >>>> Arfrever Frehtes Taifersar Arahesis said: >>>>> 2010-07-05 20:00:11 Mark Loeser napisa=C5=82(a): >>>>>> Everyone else has already made valid points. I'm just picking thi= s one >>>>>> to reply to now. Please remove the colors you have added. If you= need >>>>>> a new function, say "eqawarn", we should have that added in the ne= xt >>>>>> EAPI with a description of when and where to use it. >>>>> >>>>> In case of the colored message added in this patch, if einfo/elog/e= warn/eqawarn/eerror was used, >>>>> then its output wouldn't be logged by Portage. >>>> >>>> I don't understand what you are trying to say. >>> >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called = in global scope. >> >> Can you point to the location of python.eclass / distutils.eclass wher= e >> you need to send output from global scope, please? >=20 > It's at the beginning of this patch. NEED_PYTHON is parsed in global sc= ope. >=20 OK, so let me get this right... are trying to justify using all of the echo+custom colorization in the eclass by this one occurance, in basis of it doesn't get logged otherwise? Seems a bit far fetch. Also I'm not convinced if it's beneficial to log this.