From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O6qDn-0000v4-WD for garchives@archives.gentoo.org; Tue, 27 Apr 2010 19:13:28 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1C30DE085C; Tue, 27 Apr 2010 19:13:21 +0000 (UTC) Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by pigeon.gentoo.org (Postfix) with ESMTP id 52C31E0841 for ; Tue, 27 Apr 2010 19:12:53 +0000 (UTC) Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id 810CE818180 for ; Tue, 27 Apr 2010 21:12:50 +0200 (CEST) Received: from [192.168.0.10] (bdv75-1-81-57-102-74.fbx.proxad.net [81.57.102.74]) by smtp3-g21.free.fr (Postfix) with ESMTP id 8803D8180DE for ; Tue, 27 Apr 2010 21:12:48 +0200 (CEST) Message-ID: <4BD736D5.9020201@gentoo.org> Date: Tue, 27 Apr 2010 21:11:17 +0200 From: =?UTF-8?B?UsOpbWkgQ2FyZG9uYQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Requiring two sets of eyes for all eclass commits References: <4BD32D26.5090005@gentoo.org> In-Reply-To: <4BD32D26.5090005@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 78b2ed29-54ed-4d79-93a8-5097f7004fc9 X-Archives-Hash: 10851c7b19dc683e1bbab3aa2d00cd1d Le 24/04/2010 19:40, Petteri R=C3=A4ty a =C3=A9crit : > What do you think about not allowing commits to eclasses without > mentioning an another developer who has reviewed and approved the diff > in the commit message? There's enough people on gentoo-dev for urgent > stuff too. More bureaucracy and policies when we arguably have enough (or even too much...?) My vote is a clear and resounding *no*. If someone f*cks up, revert the commit if the issue isn't fixed quickly. If that someone f*cks up again, call devrel on his ass. If anything, we should be working on versionned eclasses rather than VCS hooks. My 2 euro cents. Cheers, R=C3=A9mi