From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O61bR-0004gu-Sz for garchives@archives.gentoo.org; Sun, 25 Apr 2010 13:10:31 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DA865E0985; Sun, 25 Apr 2010 13:10:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 4F98DE0956 for ; Sun, 25 Apr 2010 13:10:10 +0000 (UTC) Received: from [82.130.46.197] (qiv5.kyla.fi [82.130.46.197]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 1D3931B4006 for ; Sun, 25 Apr 2010 13:10:07 +0000 (UTC) Message-ID: <4BD43F32.3090409@gentoo.org> Date: Sun, 25 Apr 2010 16:10:10 +0300 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8.1.23) Gecko/20090916 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Requiring two sets of eyes for all eclass commits References: <4BD32D26.5090005@gentoo.org> <20100424201404.32b5ad52@gentoo.org> <4BD415F0.2040007@gentoo.org> <201004261042.36116.ali_bush@gentoo.org> In-Reply-To: <201004261042.36116.ali_bush@gentoo.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=B8E4ECF0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF6C824639055D69A6A696E2F" X-Archives-Salt: c3a7620f-20f3-4b94-9811-bbf48c62dda1 X-Archives-Hash: d94cb77681257dd1d60a3d0e89a440ee This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF6C824639055D69A6A696E2F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/26/2010 01:42 AM, Alistair Bush wrote: >> On 04/24/2010 09:14 PM, Alexis Ballier wrote: >>> On Sat, 24 Apr 2010 20:40:54 +0300 >>> >>> Petteri R=C3=A4ty wrote: >>>> 17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to= >>>> CVS if the commit message doesn't match a certain pattern? >>>> 17:36 <@robbat2|na> go and checkout the CVSROOT and there should be = an >>>> example there >>>> 17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks. >>>> >>>> What do you think about not allowing commits to eclasses without >>>> mentioning an another developer who has reviewed and approved the di= ff >>>> in the commit message? There's enough people on gentoo-dev for urgen= t >>>> stuff too. >>> >>> no thanks; we already have the policy to require that major changes t= o >>> broad impact eclasses have gone through -dev, no need to add more >>> bureaucracy. >> >> But the policy is not tested by the quizzes and we have had cases late= ly >> where large diffs have been committed without gentoo-dev review. With >> peer review it's likely that the reviewer is familiar with what should= >> be sent to gentoo-dev as hesitant/new people won't give their approval= >> that easily. >=20 > 1) Why is it of any relevance whether or not the quizzes test this pol= icy? =20 I doubt recruits read all of our documentation while answering the quizzes. This would just enforce behavior. > 2) Where is this policy recorded, and why does devmanual.g.o seem to=20 > (possibly) contradict it? [1] I'm not sure of the nature of the commit= s but=20 > were they non-general? >=20 http://devmanual.gentoo.org/eclass-writing/index.html "Before updating eutils or a similar widely used eclass, it is best to email the gentoo-dev list." >=20 > [1] "It is not usually necessary to email the gentoo-dev list before ma= king=20 > changes to a non-general eclass which you maintain. Use common sense he= re." Yeah it's not spelled that clearly there. Regards, Petteri --------------enigF6C824639055D69A6A696E2F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJL1D81AAoJEPeUsk245OzwICgQALm4tH8NyUbVxbS5bC0DX3H6 w34cAEwSyOrc2nhUb4snKpuEdfGQrSyq26e2mZ+lkIB19rZcclhfmdtiVzeVXN2E 83PpNVmi6STToSG3fm86PWesuqLv3PzP8geDATjf0t2y++fRcMMX8/9NYlc6VW1p oS786UD+g+RJ1P1LzMmHtqAIgzRGRUTKXsWdFqaqzmwpvXkRvAHWH4KmAmKYTr+P MBjPoFsJRk0geMjULeI7K1aPgdWeJQvKSsM6Gb5saL9zRFQtCMIB6rCfHwVadfuJ ZmifeTttFCSjBSVaRa/HMQ80Jus2deYGiN2TO2KAUOOPsY9dg5QJrwWMLa3O+9Q/ naULLuzP0GU7HeWHYaT9iRXpaOUUSHZ/d4fqfnj+W1HWgG9IMZ0MOTyRHQkWAeCl 4SNptggMfyJTF0/srXEL9CAhZmZoTavhh4lEPomJfitSXoz7yP58U1h1Y94iDO2T q5RlWtGSnFXK66Olt0zF4wQp/eNZw3Y3A4EfFRNlt1sUCxN5ND38eICUtj889Sgh jA194yVq6wOApvs1ZMTyKhrd5cbyZpUrxkzHHeDnPtqML67zVaStdtn8hSeQhdDL Yo+OJ1DIqDI8Jxx7oCtNLBGi2eZJedo/g0V5fu5ZkKNXNgaIvEWiTvHlX6gQ3d+z jLYojrFC5He439+Yeobf =S480 -----END PGP SIGNATURE----- --------------enigF6C824639055D69A6A696E2F--