From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O60Zl-00055N-RJ for garchives@archives.gentoo.org; Sun, 25 Apr 2010 12:04:42 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A9397E0958; Sun, 25 Apr 2010 12:04:40 +0000 (UTC) Received: from vms173005pub.verizon.net (vms173005pub.verizon.net [206.46.173.5]) by pigeon.gentoo.org (Postfix) with ESMTP id 115C0E093B for ; Sun, 25 Apr 2010 12:04:37 +0000 (UTC) Received: from gw.thefreemanclan.net ([unknown] [96.245.231.248]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0L1F00K4BLJ9XIY0@vms173005.mailsrvcs.net> for gentoo-dev@lists.gentoo.org; Sun, 25 Apr 2010 07:04:26 -0500 (CDT) Received: from [192.168.0.5] (rich.homedns.org [192.168.0.5]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by gw.thefreemanclan.net (Postfix) with ESMTPS id 6700A1759DD7 for ; Sun, 25 Apr 2010 08:04:20 -0400 (EDT) Message-id: <4BD42FBF.7010901@gentoo.org> Date: Sun, 25 Apr 2010 08:04:15 -0400 From: Richard Freeman User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100421 Thunderbird/3.0.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits References: <4BD32D26.5090005@gentoo.org> <20100425040601.5dc8e5d7@gentoo.org> <4BD4153F.5000509@gentoo.org> <20100425053625.6a72ee87@gentoo.org> In-reply-to: <20100425053625.6a72ee87@gentoo.org> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Archives-Salt: bca3cbbc-5469-4e1c-ace1-d1dac36e335a X-Archives-Hash: f1bbb5abe728bbd3414da86e4555e71d On 04/25/2010 07:36 AM, Ryan Hill wrote: > People make mistakes. Agreed - at work I've often found a quality mindset that is 100% focused on preventing mistakes, and I've found that these kinds of systems are almost equally as focused on preventing them from being fixed (three minutes to fix a bug, three weeks to document and release the fix - then we wonder why the system has hundreds of trivial open bugs with no ROI for fixing them). A good quality system isn't just about preventing mistakes - it needs to be about fixing them too. The system that prevents typos from getting into the tree shouldn't get in the way of those typos being fixed. There needs to be a balance. Scripts running on repository servers don't have a sense of balance, so they aren't the answer. Nor is cutting off hands any time a dev messes up unless it becomes a pattern or there is malicious intent. However, a systematic review process is probably a good thing most of the time, and published policies supporting this are a good thing. Rich