From: "Petteri Räty" <betelgeuse@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits
Date: Sun, 25 Apr 2010 13:11:11 +0300 [thread overview]
Message-ID: <4BD4153F.5000509@gentoo.org> (raw)
In-Reply-To: <20100425040601.5dc8e5d7@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On 04/25/2010 01:06 PM, Ryan Hill wrote:
> On Sat, 24 Apr 2010 20:40:54 +0300
> Petteri Räty <betelgeuse@gentoo.org> wrote:
>
>> What do you think about not allowing commits to eclasses without
>> mentioning an another developer who has reviewed and approved the diff
>> in the commit message? There's enough people on gentoo-dev for urgent
>> stuff too.
>
> I think it's a good idea to strongly encourage it, but actually forcing it
> through cvs? No thanks. I'm not tracking down another dev just to fix a
> spelling mistake. :P
>
>
How did the spelling mistake get there in the first place? A review
system should reduce having them in the first place.
Regards,
Petteri
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]
next prev parent reply other threads:[~2010-04-25 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 17:40 [gentoo-dev] Requiring two sets of eyes for all eclass commits Petteri Räty
2010-04-24 18:10 ` Arun Raghavan
2010-04-24 18:14 ` Alexis Ballier
2010-04-25 10:14 ` Petteri Räty
2010-04-25 22:42 ` Alistair Bush
2010-04-25 13:10 ` Petteri Räty
2010-04-25 15:22 ` Jorge Manuel B. S. Vicetto
2010-04-26 17:58 ` Steev Klimaszewski
2010-04-25 10:06 ` [gentoo-dev] " Ryan Hill
2010-04-25 10:11 ` Petteri Räty [this message]
2010-04-25 11:36 ` Ryan Hill
2010-04-25 12:01 ` Alec Warner
2010-04-25 21:06 ` Ryan Hill
2010-04-25 12:04 ` Richard Freeman
2010-04-26 16:19 ` Paul Varner
2010-04-25 10:54 ` [gentoo-dev] " Roy Bamford
2010-04-27 19:11 ` Rémi Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD4153F.5000509@gentoo.org \
--to=betelgeuse@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox