From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NoKmM-0008Pa-DT for garchives@archives.gentoo.org; Sun, 07 Mar 2010 18:00:41 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E15D5E07A3; Sun, 7 Mar 2010 18:00:33 +0000 (UTC) Received: from mail-yx0-f177.google.com (mail-yx0-f177.google.com [209.85.210.177]) by pigeon.gentoo.org (Postfix) with ESMTP id D02BDE0A6A for ; Sun, 7 Mar 2010 18:00:19 +0000 (UTC) Received: by yxe7 with SMTP id 7so58490yxe.32 for ; Sun, 07 Mar 2010 10:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=1VSOcd/SZjarFrXAifAEj14m8g8irdSNutD0VU2b1ug=; b=DtNCJ5ISs1PyQW8DWLU1LWo/s4aN5yX4mXZ38AxzJNPK3GW1u5rA0Bd0U+Ayj5nywQ aC+v7hR/Powb4nYg+CpJ2Pp7nj3CiHMZzja73Mu3PN/FP3OiJGpsJ4w1S1C2Z2ZOnKdH vxWJcnS4d2M6WetQWfWbl1rb6WH7HN6W8e5Wo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=rnJHLOYGhH4GsHoKhm9erbl3upR+qEd3kXncEht8TlHxWrYWhu6QMsl27HEw2iwcCn Wr00/mhjOVa3InIrPKT87/OY7XJDdR13dfxWROhCz8RTog/R20RGnHgCEqDv4FaoXDOs w7BIJkzHcTRlsp3xdQBxw4eKkNWw+w5yVEeeY= Received: by 10.151.89.35 with SMTP id r35mr3271334ybl.183.1267984819417; Sun, 07 Mar 2010 10:00:19 -0800 (PST) Received: from [192.168.1.100] ([190.1.21.180]) by mx.google.com with ESMTPS id 5sm1069119yxd.17.2010.03.07.10.00.17 (version=SSLv3 cipher=RC4-MD5); Sun, 07 Mar 2010 10:00:18 -0800 (PST) Message-ID: <4B93F78D.90300@gmail.com> Date: Sun, 07 Mar 2010 15:59:25 -0300 From: ChIIph User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100222 Thunderbird/3.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Changes to flag-o-matic's _filter-var References: <4B858BA9.2070300@gmail.com> <201003062127.48227.vapier@gentoo.org> <4B93E85A.6030908@gmail.com> <201003071250.04043.vapier@gentoo.org> In-Reply-To: <201003071250.04043.vapier@gentoo.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5B14B0A3A19D79BE42C8B8F2" X-Archives-Salt: 29c11590-68f1-4663-a9a3-c20c0aaaafd2 X-Archives-Hash: 9ba875d16d385ea53b17f13424608fb8 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5B14B0A3A19D79BE42C8B8F2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/07/10 14:50, Mike Frysinger wrote: > On Sunday 07 March 2010 12:54:34 ChIIph wrote: > =20 >> [snip] >> The commas are only added when there's LDFLAGS being changed. >> =20 > you missed my point. read the whole eclass -- this function isnt only = used on=20 > LDFLAGS. your patch opens the door to incorrectly split/mangle other=20 > variables. > =20 I know, what I wanted to say is that I've tested those changes with more than filter-ldflags funtion, and I proposed it here because it works in every case. > =20 >>> plus, there are a few other ways to trick the system. >>> >>> my opinion is still: >>> - bypassing the system is sometimes useful >>> - use separate -Wl flags and things just work >>> =20 >> Ok, but in the default profiles LDFLAGS are separated with commas, so >> for that second opinion to be possible, I think that should be changed= =2E >> =20 > i really have no idea what you're talking about. no default profile us= es the=20 > multi-linker flag form. > =20 grep -nR LDFLAGS /usr/portage/profiles/* (...) /usr/portage/profiles/default/linux/make.defaults:53:LDFLAGS=3D"-Wl,-O1" (...) > =20 >> On the other hand, a lot of us use comma separated flags, so for all o= f >> us filter-ldflags doesn't work, and what I've modify doesn't mess with= >> any of all the other function (or at least I haven't found the case in= >> which it does). >> =20 > then change your LDFLAGS > =20 Yes, of course, but the not-comma separated form of LDFLAGS isn't the most commonly used one. So it's not that I'm a case of rebelty :) > =20 >> Anyway, filter-ldflags doesn't work like it is right now, I'm not sayi= ng >> use _my_ code, but use whatever you think it's best to fix this. >> =20 > i dont see any bug so you're going to have to be more specific > -mike > =20 --------------enig5B14B0A3A19D79BE42C8B8F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAkuT95cACgkQleOIHZp1Omse5gCdGeGNCxKvnqkak/mjK9JM6yK3 U+4AmwQsqRm8sFDEpdocMrgZVDeAnhTo =Bjst -----END PGP SIGNATURE----- --------------enig5B14B0A3A19D79BE42C8B8F2--