From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NoJlb-0005xA-DQ for garchives@archives.gentoo.org; Sun, 07 Mar 2010 16:55:47 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E3DD2E0808; Sun, 7 Mar 2010 16:55:41 +0000 (UTC) Received: from mail-gw0-f53.google.com (mail-gw0-f53.google.com [74.125.83.53]) by pigeon.gentoo.org (Postfix) with ESMTP id B7EDDE07DD for ; Sun, 7 Mar 2010 16:55:23 +0000 (UTC) Received: by gwj19 with SMTP id 19so2318272gwj.40 for ; Sun, 07 Mar 2010 08:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=51N4ER4SVhM93tjWWpz2H/gc2F6jI6myuCBfayTjhp0=; b=YYVgecSg0egQg2xxuI+MVwPTtXweARQ50/jUOuAD2zfPdrbDVGvwDzqmzn6gIzBtc3 8OjT3AaCkzxWFRwgCXZX/OPJqig46BFzDsd5vcRgDjacSpkW02X6HGdn7R4erMn1uQmp A7EuVr4ozPJTj93p0N7jtV+N07fEWOgJVPkLo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=s5Y7y2XSdZ8ilNwDrUVqvbVyekD6/dU6sVNJ9who0JgLPi4wJS+dyzwc1x77jG2eL2 lULDRNLILQkpSYhC7nJGnCuR9NXNyBFVeyTUkAsxxOpkx4XQP66206ynvdi7VJoE/aHi gYU19kXrAOR3W2tOhtxHw2K1ayrI6VKrB8ErQ= Received: by 10.100.55.20 with SMTP id d20mr7296044ana.66.1267980923305; Sun, 07 Mar 2010 08:55:23 -0800 (PST) Received: from [192.168.1.100] ([190.1.21.180]) by mx.google.com with ESMTPS id 6sm1060739yxg.30.2010.03.07.08.55.22 (version=SSLv3 cipher=RC4-MD5); Sun, 07 Mar 2010 08:55:22 -0800 (PST) Message-ID: <4B93E85A.6030908@gmail.com> Date: Sun, 07 Mar 2010 14:54:34 -0300 From: ChIIph User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100222 Thunderbird/3.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Changes to flag-o-matic's _filter-var References: <4B858BA9.2070300@gmail.com> <201003062127.48227.vapier@gentoo.org> In-Reply-To: <201003062127.48227.vapier@gentoo.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5C70A846DECC8839C3445A33" X-Archives-Salt: 566641df-484a-41b6-80f9-1615d509f8fa X-Archives-Hash: 0f7213be8dbeb92e793e55ecf86bee52 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5C70A846DECC8839C3445A33 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/10 23:27, Mike Frysinger wrote: > On Wednesday 24 February 2010 15:27:21 ChIIph wrote: > =20 >> Here are some minor changes I'd like to propose to flag-o-matic's >> _filter-var() to work properly with LDFLAGS. >> Without this, things like "-Wl,-O1,--as-needed" won't be affected by a= ny >> kind of filter since there are no spaces to separate each flag. >> >> I don't know of any better way to do this, but here's a patch that wor= ks >> just fine. >> =20 > the func is used by other code where you dont want to screw with commas= =2E =20 > =20 The commas are only added when there's LDFLAGS being changed. > plus, there are a few other ways to trick the system. > > my opinion is still: > - bypassing the system is sometimes useful > - use separate -Wl flags and things just work > =20 Ok, but in the default profiles LDFLAGS are separated with commas, so for that second opinion to be possible, I think that should be changed. On the other hand, a lot of us use comma separated flags, so for all of us filter-ldflags doesn't work, and what I've modify doesn't mess with any of all the other function (or at least I haven't found the case in which it does). > so thanks, but no thanks > -mike > =20 Anyway, filter-ldflags doesn't work like it is right now, I'm not saying use _my_ code, but use whatever you think it's best to fix this. (Please, don't CC me, I'm already in gentoo-dev list) Cheers, Tomas --------------enig5C70A846DECC8839C3445A33 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAkuT6F4ACgkQleOIHZp1Oms8VgCgh22CCUOJ+S7PZUm4lOaK31oB 290An0SjRa6JetqoBCSo+dTa39z+L7yx =Vnxl -----END PGP SIGNATURE----- --------------enig5C70A846DECC8839C3445A33--