From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NjKwb-0004Ni-Tb for garchives@archives.gentoo.org; Sun, 21 Feb 2010 23:10:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8777BE064F for ; Sun, 21 Feb 2010 23:10:33 +0000 (UTC) Received: from petteriraty.eu (host.petteriraty.eu [188.40.80.83]) by pigeon.gentoo.org (Postfix) with ESMTP id E863CE0B90 for ; Sun, 21 Feb 2010 23:00:47 +0000 (UTC) Received: from Petteri-Ratys-MacBook-Pro.local (d207-6-248-62.bchsia.telus.net [207.6.248.62]) by petteriraty.eu (Postfix) with ESMTPSA id A8D0030658 for ; Sun, 21 Feb 2010 23:00:46 +0000 (UTC) Message-ID: <4B81BB1C.3070907@gentoo.org> Date: Sun, 21 Feb 2010 15:00:44 -0800 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: ACCEPT_LICENSE and deprecation of check_license References: <4B8061F7.8050504@gentoo.org> <4B816881.8050608@gentoo.org> <4B81B0FC.60801@gentoo.org> <4B81B582.2070306@gentoo.org> <4B81B887.8030706@gentoo.org> In-Reply-To: <4B81B887.8030706@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 86fb6920-782b-4b00-b913-e96e5dc79d14 X-Archives-Hash: ecd14d70e8876bca85d5a61aad8de4db On 21.2.2010 14.49, Zac Medico wrote: > On 02/21/2010 02:36 PM, Petteri R=C3=A4ty wrote: >> On 21.2.2010 14.17, Zac Medico wrote: >>> On 02/21/2010 09:08 AM, Petteri R=C3=A4ty wrote: >>>> On 20.2.2010 14.28, Zac Medico wrote: >>>>> Hi, >>>>> >>>>> Since portage-2.1.7.x is stable now, with ACCEPT_LICENSE support, w= e >>>>> can think about deprecating check_license [1]. This will allow us t= o >>>>> avoid using PROPERTIES=3Dinteractive in cases when it is due to >>>>> check_license alone, since anything with a license in the @EULA >>>>> license group is automatically masked by the default >>>>> ACCEPT_LICENSE=3D"* -@EULA" portage configuration [2]. >>>>> >>>>> [1] http://bugs.gentoo.org/show_bug.cgi?id=3D299095 >>>>> [2] http://bugs.gentoo.org/show_bug.cgi?id=3D302645 >>>> >>>> We could handle it like deprecating ebeep and epause. With EAPI=3D4 = don't >>>> define the function any more and the Portage version will be >>>> sufficiently new to have ACCEPT_LICENSE. >>> >>> That's a good idea. However, we may want to deprecate check_license >>> it starting with EAPI=3D3 since the corresponding portage versions >>> already support ACCEPT_LICENSE. >> >> Likely there wouldn't be any breakage with it doing it in EAPI 3 but i= t >> would be against the eclass contract of not changing expected behavior= . >=20 > Given that check_license already returns silently if the user has > accepted the appropriate license(s) via ACCEPT_LICENSE, it's not > necessary to change the eclass contract in order to safely remove > PROPERTIES=3Dinteractive from EAPI=3D3 ebuilds. So we could keep check_license defined in EAPI 3 and remove interactive from PROPERTIES and in EAPI 4 undefine it. We should also have a repoman check so developers catch it. Regards, Petteri