From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NiFgf-0002bE-G6 for garchives@archives.gentoo.org; Thu, 18 Feb 2010 23:21:37 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3E672E09B6; Thu, 18 Feb 2010 23:21:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 7F1DDE099B for ; Thu, 18 Feb 2010 23:21:31 +0000 (UTC) Received: from [192.168.1.4] (smer.tone.cz [89.250.247.23]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id B3C2C1B4149 for ; Thu, 18 Feb 2010 23:21:30 +0000 (UTC) Message-ID: <4B7DCB51.3050505@gentoo.org> Date: Fri, 19 Feb 2010 00:20:49 +0100 From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100216 Thunderbird/3.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] New eclass for x11 packages References: <4B7DC046.7010001@gentoo.org> <201002182311.38065.levertond@googlemail.com> <4B7DCA66.3040507@gentoo.org> In-Reply-To: <4B7DCA66.3040507@gentoo.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 24754a6b-2ec6-4226-bfa9-d43822ab754e X-Archives-Hash: 2adda5696110fad28b2f23846c4ffc73 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> [[ -e "./configure.ac" ]] && eautoreconf || ewarn "Unable to autoreconf >> the configure script. Things may fail." > >> That'll ewarn if configure.ac doesn't exist at all. Doesn't eautoreconf die >> anyway if it fails, and if not, is it a good idea for failures to only give a >> warning? > > That || die is not for eautoreconf > > [[ -e "something" ]] && somethingexists || somethingisnotexisting > > For your behaviour it would have to look like this > > [[ -e "something" ]] && { somethingexists || die if the commands failed ; } > Mea culpa, now I see you ask if I should not die if that configure.ac is not found. Well the issue is that things Might fail, not 100% fail :] and it is for prefix only so we can update behaviour for it later to be more strict. Tomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkt9y1EACgkQHB6c3gNBRYdkqQCgpCsvS1tJQbeP7sZaxP9xNn1m ogsAoIrPbn8ilxnTd5oXT77lSXsju0g4 =4/mJ -----END PGP SIGNATURE-----